From: Andrew Morton <akpm@linux-foundation.org>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Jules Irenge <jbi.octave@gmail.com>,
linux-kernel@vger.kernel.org, boqun.feng@gmail.com,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Gang He <ghe@suse.com>, Richard Fontana <rfontana@redhat.com>,
Allison Randal <allison@lohutok.net>,
Thomas Gleixner <tglx@linutronix.de>,
Aditya Pakki <pakki001@umn.edu>, ChenGang <cg.chen@huawei.com>,
Masahiro Yamada <masahiroy@kernel.org>,
"moderated list:ORACLE CLUSTER FILESYSTEM 2 (OCFS2)"
<ocfs2-devel@oss.oracle.com>
Subject: Re: [PATCH 3/5] ocfs2: Add missing annotation for dlm_empty_lockres()
Date: Wed, 15 Apr 2020 20:02:01 -0700 [thread overview]
Message-ID: <20200415200201.2efbbbd338a43a2f57988e2d@linux-foundation.org> (raw)
In-Reply-To: <5408edd7-87a9-ac56-5c52-c2a19c308311@linux.alibaba.com>
On Sat, 4 Apr 2020 07:45:49 +0800 Joseph Qi <joseph.qi@linux.alibaba.com> wrote:
> On 2020/4/4 00:05, Jules Irenge wrote:
> > Sparse reports a warning at dlm_empty_lockres()
> >
> > warning: context imbalance in dlm_purge_lockres() - unexpected unlock
> >
> > The root cause is the missing annotation at dlm_purge_lockres()
> >
> > Add the missing __must_hold(&dlm->spinlock)
> >
> Seems this is duplicate with assert_spin_locked()?
I doubt is sparse is smart enough to treat assert_spin_locked() as
equivalent to __must_hold(). It would be neat though.
next prev parent reply other threads:[~2020-04-16 3:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/5>
2020-04-03 16:05 ` [PATCH 0/5] lock warnings cleanup Jules Irenge
2020-04-03 16:05 ` [PATCH 1/5] ipc/msg: Add missing annotation for freeque() Jules Irenge
2020-04-03 16:05 ` [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc() Jules Irenge
2020-04-07 19:48 ` Sam Ravnborg
2020-04-03 16:05 ` [PATCH 3/5] ocfs2: Add missing annotation for dlm_empty_lockres() Jules Irenge
2020-04-03 23:45 ` Joseph Qi
2020-04-16 3:02 ` Andrew Morton [this message]
2020-04-03 16:05 ` [PATCH 4/5] libata: Add missing annotation for ata_scsi_rbuf_get() and ata_scsi_rbuf_fill() Jules Irenge
2020-04-03 16:05 ` [PATCH 5/5] ipmi: Add missing annotation for ipmi_ssif_lock_cond() and ipmi_ssif_unlock_cond() Jules Irenge
2020-04-03 18:35 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415200201.2efbbbd338a43a2f57988e2d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=allison@lohutok.net \
--cc=boqun.feng@gmail.com \
--cc=cg.chen@huawei.com \
--cc=ghe@suse.com \
--cc=jbi.octave@gmail.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=masahiroy@kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=pakki001@umn.edu \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox