From: Lee Jones <lee.jones@linaro.org>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd:asic3:Delete redundant variable definition
Date: Thu, 16 Apr 2020 08:08:02 +0100 [thread overview]
Message-ID: <20200416070802.GQ2167633@dell> (raw)
In-Reply-To: <20200403042020.17452-1-tangbin@cmss.chinamobile.com>
On Fri, 03 Apr 2020, Tang Bin wrote:
> In this function, 'ret' is always assigned, even if 'pdata->leds'
> don't carry out,it has already been assigned a value in the above
> code, including '0',so it's redundant.
Which line initialises/assigns 'ret' before this one?
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/mfd/asic3.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> index a6bd2134c..cee7454b3 100644
> --- a/drivers/mfd/asic3.c
> +++ b/drivers/mfd/asic3.c
> @@ -924,7 +924,6 @@ static int __init asic3_mfd_probe(struct platform_device *pdev,
> goto out;
> }
>
> - ret = 0;
> if (pdata->leds) {
> int i;
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-04-16 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 4:20 [PATCH] mfd:asic3:Delete redundant variable definition Tang Bin
2020-04-16 7:08 ` Lee Jones [this message]
2020-04-16 9:57 ` Tang Bin
2020-04-17 9:27 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2020-04-03 8:11 [PATCH] mfd: asic3: Delete " Markus Elfring
2020-04-03 9:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416070802.GQ2167633@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox