* [PATCH -next] mfd: stpmic1: Make stpmic1_regmap_config static
@ 2020-04-10 11:55 YueHaibing
2020-04-16 9:45 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-04-10 11:55 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, YueHaibing
Fix sparse warning:
drivers/mfd/stpmic1.c:62:28: warning:
symbol 'stpmic1_regmap_config' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mfd/stpmic1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c
index 7dfbe8906cb8..eb3da558c3fb 100644
--- a/drivers/mfd/stpmic1.c
+++ b/drivers/mfd/stpmic1.c
@@ -59,7 +59,7 @@ static const struct regmap_access_table stpmic1_volatile_table = {
.n_yes_ranges = ARRAY_SIZE(stpmic1_volatile_ranges),
};
-const struct regmap_config stpmic1_regmap_config = {
+static const struct regmap_config stpmic1_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.cache_type = REGCACHE_RBTREE,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] mfd: stpmic1: Make stpmic1_regmap_config static
2020-04-10 11:55 [PATCH -next] mfd: stpmic1: Make stpmic1_regmap_config static YueHaibing
@ 2020-04-16 9:45 ` Lee Jones
0 siblings, 0 replies; 3+ messages in thread
From: Lee Jones @ 2020-04-16 9:45 UTC (permalink / raw)
To: YueHaibing; +Cc: linux-kernel
On Fri, 10 Apr 2020, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/mfd/stpmic1.c:62:28: warning:
> symbol 'stpmic1_regmap_config' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/mfd/stpmic1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] mfd: stpmic1: Make stpmic1_regmap_config static
@ 2019-03-22 14:08 Yue Haibing
0 siblings, 0 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-22 14:08 UTC (permalink / raw)
To: p.paillet, lee.jones; +Cc: linux-kernel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/mfd/stpmic1.c:62:28: warning:
symbol 'stpmic1_regmap_config' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mfd/stpmic1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c
index 7dfbe89..eb3da55 100644
--- a/drivers/mfd/stpmic1.c
+++ b/drivers/mfd/stpmic1.c
@@ -59,7 +59,7 @@ static const struct regmap_access_table stpmic1_volatile_table = {
.n_yes_ranges = ARRAY_SIZE(stpmic1_volatile_ranges),
};
-const struct regmap_config stpmic1_regmap_config = {
+static const struct regmap_config stpmic1_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.cache_type = REGCACHE_RBTREE,
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 9:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-10 11:55 [PATCH -next] mfd: stpmic1: Make stpmic1_regmap_config static YueHaibing
2020-04-16 9:45 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2019-03-22 14:08 Yue Haibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox