From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wei Liu <wei.liu@kernel.org>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Colin Ian King <colin.king@canonical.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH][next] drivers: hv: remove redundant assignment to pointer primary_channel
Date: Thu, 16 Apr 2020 13:02:54 +0300 [thread overview]
Message-ID: <20200416100253.GN1163@kadam> (raw)
In-Reply-To: <20200415143752.cm3xbesiuksfdbzm@debian>
We have this discussion over and over. I always say it helps to have
the commit mentioned in the commit message but it's not a Fixes tag.
So I think that the commit message should say something like
"commit 1234234 ("blah blah") removed some code so this variable isn't
used any more". I think it helps the review process. But then if we
mention the commit everyone says to use the Fixes tag.
It turns out if you leave out the commit entirely then people still
complain but a lot less frequently. It shouldn't work that way but
reviewers are illogical.
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-16 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:23 [PATCH][next] drivers: hv: remove redundant assignment to pointer primary_channel Colin King
2020-04-14 15:42 ` Julia Lawall
2020-04-14 16:51 ` Vitaly Kuznetsov
2020-04-14 16:58 ` Colin Ian King
2020-04-15 10:43 ` Vitaly Kuznetsov
2020-04-15 14:37 ` Wei Liu
2020-04-16 10:02 ` Dan Carpenter [this message]
2020-04-16 10:08 ` Colin Ian King
2020-04-14 20:24 ` Wei Liu
2020-04-14 21:25 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416100253.GN1163@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=haiyangz@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox