From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31AEAC2BB55 for ; Thu, 16 Apr 2020 14:51:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE0FB21D93 for ; Thu, 16 Apr 2020 14:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587048671; bh=Mh3AGzpSVVNlEmzjAtk+AFJDbUsAPb4V+DNYqMwXSuk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QT8HG3g/csJPzygl5yl87IDlzdtVKfOrc5+Egf+TCQPDeWSdyJX+YCQMoMTTzmKm6 9XCCzc0dndMqRWMeeAqbHkb61dV2Fk5gIeKRJOCtnyTVHBJV3L61I2Ska/v2+Ma+4H FwP3b7J9ybs6YfcXBHWtHgHjRHv+oYVIDXKhTYg8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394674AbgDPOvG (ORCPT ); Thu, 16 Apr 2020 10:51:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:45128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2441733AbgDPN6J (ORCPT ); Thu, 16 Apr 2020 09:58:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D597217D8; Thu, 16 Apr 2020 13:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587045488; bh=Mh3AGzpSVVNlEmzjAtk+AFJDbUsAPb4V+DNYqMwXSuk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xxKGv6dmjcR4ketmoid6oWkfRhqBdw2aYRRQIF49Y/vLG7nSy2756WpuDjyBWRM8u QC+hGFICg5p9SiIVDyhYBuFjfjlIAywXS+RhTvEmEE2VkO5gAy4r+arIbNanPehxt5 8VjQ1j8jsXURLDPiCJFrJZ59bAMdv+Y1S9cXJVXA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robbie Ko , Filipe Manana , David Sterba Subject: [PATCH 5.6 156/254] btrfs: fix missing semaphore unlock in btrfs_sync_file Date: Thu, 16 Apr 2020 15:24:05 +0200 Message-Id: <20200416131346.136980688@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131325.804095985@linuxfoundation.org> References: <20200416131325.804095985@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Robbie Ko commit 6ff06729c22ec0b7498d900d79cc88cfb8aceaeb upstream. Ordered ops are started twice in sync file, once outside of inode mutex and once inside, taking the dio semaphore. There was one error path missing the semaphore unlock. Fixes: aab15e8ec2576 ("Btrfs: fix rare chances for data loss when doing a fast fsync") CC: stable@vger.kernel.org # 4.19+ Signed-off-by: Robbie Ko Reviewed-by: Filipe Manana [ add changelog ] Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/file.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -2134,6 +2134,7 @@ int btrfs_sync_file(struct file *file, l */ ret = start_ordered_ops(inode, start, end); if (ret) { + up_write(&BTRFS_I(inode)->dio_sem); inode_unlock(inode); goto out; }