From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF15C2BB55 for ; Thu, 16 Apr 2020 15:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D660921D7E for ; Thu, 16 Apr 2020 15:14:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="slkqMMMY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2442329AbgDPPOP (ORCPT ); Thu, 16 Apr 2020 11:14:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2395069AbgDPPMS (ORCPT ); Thu, 16 Apr 2020 11:12:18 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3216DC061A10 for ; Thu, 16 Apr 2020 08:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-Id:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=0LPOq6kuy6O1K32QsrMgcnJ+qO6SmUMAmC4PPFEY/AA=; b=slkqMMMYJA/Q6+5N7QtpC8MfTj CtJkDDEtyBqtxAp2K3uXP09j6BT1ErP+xXe+TQUgIDcSKfY5+5833370Lt+r8rztrd7HHy9uLCxnY l/00cgplngYA2rJD8eFd6wT5Df5HwjW4Qx8LpE+bNCKy8q5eHsogcUZUTTzHw/Zn2/q/3hJyEdrDk JWFMuIEGQq9b6dFs7jRNRt2wUsiFiM6svWHv7WQA4P7CEJHxv5HjK7KCbE3Y4H2Viu/c8YCXIqxj3 gaPasnK1pP/P72zi/0sdyxfud2UfNX9tkPwV+KGq8eRlHLzr4NICnId8/AN+HDwjFWDYO150szyI5 +8Cw5Ehg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP6BH-00046b-LX; Thu, 16 Apr 2020 15:11:55 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 205DF306089; Thu, 16 Apr 2020 17:11:54 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 00159203C0A2B; Thu, 16 Apr 2020 17:11:53 +0200 (CEST) Message-Id: <20200416151024.763553292@infradead.org> User-Agent: quilt/0.65 Date: Thu, 16 Apr 2020 17:07:53 +0200 From: Peter Zijlstra To: jpoimboe@redhat.com, alexandre.chartre@oracle.com Cc: linux-kernel@vger.kernel.org, jthierry@redhat.com, tglx@linutronix.de, x86@kernel.org, peterz@infradead.org Subject: [RFC][PATCH 1/7] objtool: is_fentry_call() crashes if call has no destination References: <20200416150752.569029800@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexandre Chartre Fix is_fentry_call() so that it works if a call has no destination set (call_dest). This needs to be done in order to support intra- function calls. Signed-off-by: Alexandre Chartre Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20200414103618.12657-2-alexandre.chartre@oracle.com --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1490,7 +1490,7 @@ static int decode_sections(struct objtoo static bool is_fentry_call(struct instruction *insn) { - if (insn->type == INSN_CALL && + if (insn->type == INSN_CALL && insn->call_dest && insn->call_dest->type == STT_NOTYPE && !strcmp(insn->call_dest->name, "__fentry__")) return true;