From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90234C2D0EF for ; Fri, 17 Apr 2020 15:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72F0721D79 for ; Fri, 17 Apr 2020 15:22:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728835AbgDQPWq (ORCPT ); Fri, 17 Apr 2020 11:22:46 -0400 Received: from mga02.intel.com ([134.134.136.20]:22044 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728684AbgDQPWq (ORCPT ); Fri, 17 Apr 2020 11:22:46 -0400 IronPort-SDR: EoUvbtWgmFHw8Ok62J0hgdWn7X4fgceDUO8P9xTKKHtmh6Vv2Qt78For47O0QVB+zCYbtrt7ZG Uljl9clRui8w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 08:22:44 -0700 IronPort-SDR: jttx9y4XliPhN5EmpkCynjQPClqI9PL59tfFSuf/z31+Enejj5o2AgxCyiDRK4DT9ud2Ko8scm 2AlOmCiNfDuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,395,1580803200"; d="scan'208";a="279887326" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga008.jf.intel.com with ESMTP; 17 Apr 2020 08:22:44 -0700 Date: Fri, 17 Apr 2020 08:28:39 -0700 From: Jacob Pan To: Auger Eric Cc: "Tian, Kevin" , Yi L , Alex Williamson , "Raj, Ashok" , David Woodhouse , LKML , "iommu@lists.linux-foundation.org" , Jean-Philippe Brucker , Jonathan Cameron , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v11 05/10] iommu/vt-d: Add bind guest PASID support Message-ID: <20200417082839.45d6321e@jacob-builder> In-Reply-To: <2025736d-e7f2-d746-e030-e609b2f465e2@redhat.com> References: <1585939334-21396-1-git-send-email-jacob.jun.pan@linux.intel.com> <1585939334-21396-6-git-send-email-jacob.jun.pan@linux.intel.com> <20200410124557.4012b99b@jacob-builder> <6d9721a8-2198-5ecd-6c8b-fc43ff2ad7e1@redhat.com> <2025736d-e7f2-d746-e030-e609b2f465e2@redhat.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Apr 2020 09:46:55 +0200 Auger Eric wrote: > Hi Kevin, > On 4/17/20 4:45 AM, Tian, Kevin wrote: > >> From: Auger Eric > >> Sent: Thursday, April 16, 2020 6:43 PM > >> > > [...] > >>>>> + if (svm) { > >>>>> + /* > >>>>> + * If we found svm for the PASID, there must > >>>>> be at > >>>>> + * least one device bond, otherwise svm should > >>>>> be freed. > >>>>> + */ > >>>>> + if (WARN_ON(list_empty(&svm->devs))) { > >>>>> + ret = -EINVAL; > >>>>> + goto out; > >>>>> + } > >>>>> + > >>>>> + for_each_svm_dev(sdev, svm, dev) { > >>>>> + /* In case of multiple sub-devices of > >>>>> the same pdev > >>>>> + * assigned, we should allow multiple > >>>>> bind calls with > >>>>> + * the same PASID and pdev. > >>>>> + */ > >>>>> + sdev->users++; > >>>> What if this is not an mdev device. Is it also allowed? > >>> Yes. IOMMU and VT-d driver is not mdev aware. Here mdev is just an > >>> example of normal use case. You can bind the same PCI device (PF > >>> or SRIOV VF) more than once to the same PASID. Just need to > >>> unbind also. > >> > >> I don't get the point of binding a non mdev device several times > >> with the same PASID. Do you intend to allow that at userspace > >> level or prevent this from happening in VFIO? > > > > I feel it's better to prevent this from happening, otherwise VFIO > > also needs to track the bind count and do multiple unbinds at > > mm_exit. But it's not necessary to prevent it in VFIO. We can check > > here upon whether aux_domain is valid, and if not return -EBUSY. > Ah OK. So if we can detect the case here it is even better > I don't understand why VFIO cannot track, since it is mdev aware. if we don;t refcount the users, one mdev unbind will result unbind for all mdev under the same pdev. That may not be the right thing to do. > Thanks > > Eric > > > >> > >> Besides, the comment is a bit misleading as it gives the > >> impression it is only true for mdev and there is no associated > >> check. > > > > Thanks > > Kevin > > > [Jacob Pan]