From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5AE1C2BB1D for ; Fri, 17 Apr 2020 07:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 941682087E for ; Fri, 17 Apr 2020 07:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587108248; bh=VVl6eQijGUYnBJboOjeT+LbLAwqwN9J8c1/DpsLE62o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=IirCBOTXEwrdiGCi1XgawX26d2o5SvYc0Mu4TcPz3ed8QaKW3yMShKqVauGPfbyjb Op7sRoHokkgMvqXNyoiZHIW5VLBkmWRIJLwEIMgKGqeh4l+kyZDBEB2VCS+3s8BVum XVuBRCd+xuXb93wemVhwnj2cILmHJHco4ZIYAVls= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728963AbgDQHYH (ORCPT ); Fri, 17 Apr 2020 03:24:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:34898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728419AbgDQHYH (ORCPT ); Fri, 17 Apr 2020 03:24:07 -0400 Received: from coco.lan (ip5f5ad4d8.dynamic.kabel-deutschland.de [95.90.212.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4CB0E2054F; Fri, 17 Apr 2020 07:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587108247; bh=VVl6eQijGUYnBJboOjeT+LbLAwqwN9J8c1/DpsLE62o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GGtYUYFg/oe0o91C3yetUX8RyOViYWYJ/jfWLd9vExgJWm9MiA9cYb7NO6q0/V9cr KeO1MY5X2OogGXs677cfMETU7OOwBiXaL4m6tnNII03oZ7UKrGoyD7tJ8/FAQZfJwE Tq2gYkqeT2JX/3hFTlLy8IHrt2SS7RpRzRexwNfs= Date: Fri, 17 Apr 2020 09:24:02 +0200 From: Mauro Carvalho Chehab To: sy0816.kang@samsung.com Cc: Hans Verkuil , Arnd Bergmann , Greg Kroah-Hartman , Thomas Gleixner , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: v4l2-compat-ioctl32.c: copy reserved2 field in get_v4l2_buffer32 Message-ID: <20200417092402.3322e2da@coco.lan> In-Reply-To: <20200417024543.66785-1-sy0816.kang@samsung.com> References: <20200417024543.66785-1-sy0816.kang@samsung.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, 17 Apr 2020 11:45:23 +0900 sy0816.kang@samsung.com escreveu: > From: Sunyoung Kang > > get_v4l2_buffer32() didn't copy reserved2 field from userspace to driver. > So the reserved2 value is not received through compat-ioctl32 in driver. > This patch copy reserved2 field of v4l2_buffer in get_v4l2_buffer32(). Why should it copy reserved values? Those should not be used anywhere. > > Signed-off-by: Sunyoung Kang > --- > drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > index a99e82ec9ab6..e9b2b9c0ec9a 100644 > --- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > +++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c > @@ -665,6 +665,7 @@ static int get_v4l2_buffer32(struct v4l2_buffer __user *p64, > if (V4L2_TYPE_IS_OUTPUT(type)) > if (assign_in_user(&p64->bytesused, &p32->bytesused) || > assign_in_user(&p64->field, &p32->field) || > + assign_in_user(&p64->reserved2, &p32->reserved2) || > assign_in_user(&p64->timestamp.tv_sec, > &p32->timestamp.tv_sec) || > assign_in_user(&p64->timestamp.tv_usec, Thanks, Mauro