Re: [PATCH RFC 2/2] s390/mm: don't set ARCH_KEEP_MEMBLOCK

David Hildenbrand
2020-06-29T19:04:02Z

On 29.06.20 14:44, Heiko Carstens wrote:
> On Fri, Jun 26, 2020 at 06:32:15PM +0200, Heiko Carstens wrote:
>> On Fri, Apr 17, 2020 at 05:01:51PM +0200, David Hildenbrand wrote:
>>> Commit 50be63450728 ("s390/mm: Convert bootmem to memblock") mentions
>>> "The original bootmem allocator is getting replaced by memblock. To
>>> cover the needs of the s390 kdump implementation the physical
>>> memory list is used."
>>>
>>> zcore was converted to use resources instead of memblocks.
>>> memblock_discard() will *not* mess with "physmem", only with "memory" and
>>> "reserved" memblocks. So, that data will stay after early boot, to be
>>> used in arch/s390/kernel/crash_dump.c to create the ELF header from
>>> inside the 2nd (a.k.a. dumping) kernel.
>>>
>>> We no longer need ARCH_KEEP_MEMBLOCK.
>>>
>>> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
>>> Cc: Vasily Gorbik <gor@linux.ibm.com>
>>> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
>>> Cc: Philipp Rudo <prudo@linux.ibm.com>
>>> Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>> ---
>>> arch/s390/Kconfig | 1 -
>>> 1 file changed, 1 deletion(-)
>>
>> Applied, thanks!
>
> Hmm, this triggers:

Ah, I see, will have a look. Weird I didn't notice that ...

Thanks!

--
Thanks,

David / dhildenb