From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64184C38A29 for ; Fri, 17 Apr 2020 21:28:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BB9020857 for ; Fri, 17 Apr 2020 21:28:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L3lvYJft" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbgDQV2K (ORCPT ); Fri, 17 Apr 2020 17:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgDQV2J (ORCPT ); Fri, 17 Apr 2020 17:28:09 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8C5EC061A0C for ; Fri, 17 Apr 2020 14:28:09 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id y25so1653269pfn.5 for ; Fri, 17 Apr 2020 14:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OXaQ165Ni0b8WD+gPlIfNJ9eIDro22GRL0kc5Y0lP6Y=; b=L3lvYJftt+vZ3Cl/ynqir6A/dYh387oMAfxuo/9/YzDvEnmCRdDfySet804CsyD3+V +Uorn1IyqVtpQO9J5fyWfb4rqoUatDCwOpAxooKooD5hNHKQ7XMMLoKOXVlugXW4qEba cEMpFQq0agXOMVxVvPzqlPWRBdMo/o84wSuuMEFVDK9GNbTb5yugNqbqUj4hpymEETN4 lskv1ckNU3wigFhoNXP4eI8BV6gcSYr/nzaJk7RQV7wlfuBLQYjKnhZ0fRP+SEeeRrFn ZyjW0EI0RTmsF/jPBRcJE9MFUfjlN4/ZIDRxaijONBnsuld5HigAE7wuUVFjO4sfx4Or B11g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OXaQ165Ni0b8WD+gPlIfNJ9eIDro22GRL0kc5Y0lP6Y=; b=ntc8LGaa+L/gock/D24RI3S3MhjYnVyqSFPQFeWDCaOdaNJ4gCqMV6x7ubJaUfn99d 4W+dLyJWpE424pH9++DAlzG6ePJ6GT5PzozeztnkPqWBGRTy3OVVOJ7lH10PAOUBFIDn XnJeMpij5RbkBHUVCSFGcs8BzM99NtCJc/+Llm9O034W4M36tRMAei//3ktQdadcnGpI PMN3NNahEUBcFVqFPefGSjxEq38hP3YsSxv2c9X/wNTqPAOFDF78/eElGH6hHrucgQY8 D0cgpz4Bamo/s2cvW9lWNIQzBNMf//AUL4oDx2MoGsAvfmp1TUhCm3QPmbT3he/YLFEN csAA== X-Gm-Message-State: AGi0PuY3Gffw4QLlcn+SHdtZoGGz1e0/Zny97DEx+RZ3yzigjio2KhXx shhHo9W3aFu4ARx3SpH1Swz3HGYU6P8= X-Google-Smtp-Source: APiQypLGloCTLzOwQimrfyNagBcKFto5C3weAifCz0twCGZINKdgSfARSHgkKz2mCBDBxhA++qTqcA== X-Received: by 2002:a62:3044:: with SMTP id w65mr3965935pfw.270.1587158889016; Fri, 17 Apr 2020 14:28:09 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id e29sm15327461pgn.57.2020.04.17.14.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 14:28:08 -0700 (PDT) Date: Fri, 17 Apr 2020 15:28:06 -0600 From: Mathieu Poirier To: Suman Anna Cc: Markus Elfring , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Elder , Bjorn Andersson , Ohad Ben-Cohen Subject: Re: [PATCH v2 5/7] remoteproc: Restructure firmware name allocation Message-ID: <20200417212806.GB10372@xps15> References: <20200415204858.2448-1-mathieu.poirier@linaro.org> <20200415204858.2448-6-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2020 at 08:39:39AM -0500, Suman Anna wrote: > Hi Markus, > > On 4/16/20 1:26 AM, Markus Elfring wrote: > > … > > > +++ b/drivers/remoteproc/remoteproc_core.c > > > @@ -1984,14 +1984,14 @@ static int rproc_alloc_firmware(struct rproc *rproc, > > > { > > > const char *p; > > > > > > - if (!firmware) > > > + if (firmware) > > > + p = kstrdup_const(firmware, GFP_KERNEL); > > > + else > > > /* > > > * If the caller didn't pass in a firmware name then > > > * construct a default name. > > > */ > > > p = kasprintf(GFP_KERNEL, "rproc-%s-fw", name); > > > - else > > > - p = kstrdup_const(firmware, GFP_KERNEL); > > > > Can the use of the conditional operator make sense at such source code places? > > > > p = firmware ? kstrdup_const(…) : kasprintf(…); > > For simple assignments, I too prefer the ternary operator, but in this case, > I think it is better to leave the current code as is. I agree with Suman, that's why I didn't use the conditional operator. > > regards > Suman