Re: [PATCH] media: v4l2-compat-ioctl32.c: copy reserved2 field in get_v4l2_buffer32

Mauro Carvalho Chehab
2020-04-17T07:24:08Z

Em Fri, 17 Apr 2020 11:45:23 +0900
sy0816.kang@samsung.com escreveu:

> From: Sunyoung Kang <sy0816.kang@samsung.com>
>
> get_v4l2_buffer32() didn't copy reserved2 field from userspace to driver.
> So the reserved2 value is not received through compat-ioctl32 in driver.
> This patch copy reserved2 field of v4l2_buffer in get_v4l2_buffer32().

Why should it copy reserved values? Those should not be used anywhere.

>
> Signed-off-by: Sunyoung Kang <sy0816.kang@samsung.com>
> ---
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> index a99e82ec9ab6..e9b2b9c0ec9a 100644
> --- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> +++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> @@ -665,6 +665,7 @@ static int get_v4l2_buffer32(struct v4l2_buffer __user *p64,
> if (V4L2_TYPE_IS_OUTPUT(type))
> if (assign_in_user(&p64->bytesused, &p32->bytesused) ||
> assign_in_user(&p64->field, &p32->field) ||
> + assign_in_user(&p64->reserved2, &p32->reserved2) ||
> assign_in_user(&p64->timestamp.tv_sec,
> &p32->timestamp.tv_sec) ||
> assign_in_user(&p64->timestamp.tv_usec,

Thanks,
Mauro