* [PATCH v3] iio: magnetometer: ak8974: Silence deferred-probe error
@ 2020-04-18 17:12 Dmitry Osipenko
2020-04-18 18:21 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2020-04-18 17:12 UTC (permalink / raw)
To: Linus Walleij, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Andy Shevchenko
Cc: linux-iio, linux-kernel
It's not uncommon that voltage regulator becomes available later during
kernel's boot process. This patch adds info message about unavailable
regulators in a case of the deferred-probe error and also amends the
error message with a error code.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
Changelog:
v3: - Replaced dev_info() with dev_dbg().
v2: - Replaced dev_printk() with dev_info() for the deferred-probe error,
as was requested by Linus Walleij in a review comment to v1.
drivers/iio/magnetometer/ak8974.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
index d32996702110..372c80c25dd4 100644
--- a/drivers/iio/magnetometer/ak8974.c
+++ b/drivers/iio/magnetometer/ak8974.c
@@ -746,7 +746,12 @@ static int ak8974_probe(struct i2c_client *i2c,
ARRAY_SIZE(ak8974->regs),
ak8974->regs);
if (ret < 0) {
- dev_err(&i2c->dev, "cannot get regulators\n");
+ if (ret != -EPROBE_DEFER)
+ dev_err(&i2c->dev, "cannot get regulators: %d\n", ret);
+ else
+ dev_dbg(&i2c->dev,
+ "regulators unavailable, deferring probe\n");
+
return ret;
}
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] iio: magnetometer: ak8974: Silence deferred-probe error
2020-04-18 17:12 [PATCH v3] iio: magnetometer: ak8974: Silence deferred-probe error Dmitry Osipenko
@ 2020-04-18 18:21 ` Jonathan Cameron
2020-04-18 18:58 ` Dmitry Osipenko
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2020-04-18 18:21 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Linus Walleij, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Andy Shevchenko, linux-iio, linux-kernel
On Sat, 18 Apr 2020 20:12:44 +0300
Dmitry Osipenko <digetx@gmail.com> wrote:
> It's not uncommon that voltage regulator becomes available later during
> kernel's boot process. This patch adds info message about unavailable
> regulators in a case of the deferred-probe error and also amends the
> error message with a error code.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
>
> Changelog:
>
> v3: - Replaced dev_info() with dev_dbg().
>
> v2: - Replaced dev_printk() with dev_info() for the deferred-probe error,
> as was requested by Linus Walleij in a review comment to v1.
>
> drivers/iio/magnetometer/ak8974.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
> index d32996702110..372c80c25dd4 100644
> --- a/drivers/iio/magnetometer/ak8974.c
> +++ b/drivers/iio/magnetometer/ak8974.c
> @@ -746,7 +746,12 @@ static int ak8974_probe(struct i2c_client *i2c,
> ARRAY_SIZE(ak8974->regs),
> ak8974->regs);
> if (ret < 0) {
> - dev_err(&i2c->dev, "cannot get regulators\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(&i2c->dev, "cannot get regulators: %d\n", ret);
> + else
> + dev_dbg(&i2c->dev,
> + "regulators unavailable, deferring probe\n");
> +
> return ret;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] iio: magnetometer: ak8974: Silence deferred-probe error
2020-04-18 18:21 ` Jonathan Cameron
@ 2020-04-18 18:58 ` Dmitry Osipenko
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2020-04-18 18:58 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Linus Walleij, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Andy Shevchenko, linux-iio, linux-kernel
18.04.2020 21:21, Jonathan Cameron пишет:
> On Sat, 18 Apr 2020 20:12:44 +0300
> Dmitry Osipenko <digetx@gmail.com> wrote:
>
>> It's not uncommon that voltage regulator becomes available later during
>> kernel's boot process. This patch adds info message about unavailable
>> regulators in a case of the deferred-probe error and also amends the
>> error message with a error code.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>
> Applied to the togreg branch of iio.git and pushed out as testing for the
> autobuilders to play with it.
Awesome, thank you :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-18 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-18 17:12 [PATCH v3] iio: magnetometer: ak8974: Silence deferred-probe error Dmitry Osipenko
2020-04-18 18:21 ` Jonathan Cameron
2020-04-18 18:58 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox