Re: [linux-sunxi] [PATCH v3 0/7] Add support for Allwinner H6 DVFS

Ondřej Jirman
2020-04-20T10:27:14Z

On Mon, Apr 20, 2020 at 11:48:01AM +0200, megous hlavni wrote:
> Hello Clément,
>
> On Sun, Apr 19, 2020 at 03:50:04PM +0200, Clément Péron wrote:
> > Hi Sunxi maintainers and members,
> >
> > Now that required drivers are merged we can contibute on DVFS
> > support for Allwinner H6.
> >
>
> [ snip ]
>
> >
> > Changes since v2 (thanks to Maxime Ripard):
> > - Change Orange Pi boards to Orange Pi 3
> > - Change soc speed nvmem node name
> > - Fix device tree warnings
> > - Drop GPU opp tables
>
> Looks like you may have also inadverently dropped the second patch from v2
> series that implemented CPU thermal trip points.

Also it looks like the patch 1 from v2 implementing the clock properties
is missing from v3, and I don't see it being already applied anywhere.
Without that cpufreq doesn't work.

Also, thermal trip points need to be in the opp.dtsi to avoid dtc warnings
during build.

https://megous.com/git/linux/commit/?h=ths-5.7&id=cacefd7decf5ae0ce42ab4d48a13a58552929ebd

regards,
o.

> > Changes since v1 (thanks to Ondřej Jirman):
> > - Remove Polling thermal
> > - Add Orange Pi boards
> > - Remove minimal voltage change for Beelink GS1
> > - Add ramp-deplay for GPU and CPU regulators
> > - Push to thermal point to 85°C (Allwinner set them to 100°C and 115°C)
> > - Added 1.6GHz and 1.7GHz to OPP table.
> >
> > Clément Péron (6):
> > arm64: configs: Enable sun50i cpufreq nvmem
> > arm64: dts: allwinner: h6: Enable CPU opp tables for Beelink GS1
> > arm64: dts: allwinner: h6: Enable CPU opp tables for Orange Pi 3
> > arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6
> > arm64: dts: allwinner: Sort Pine H64 device-tree nodes
> > arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Pine H64
>
> You may also want to fix title of this patch to drop the GPU reference.
>
> thank you and regards,
> o.
>
> > Ondrej Jirman (1):
> > arm64: dts: allwinner: h6: Add CPU Operating Performance Points table