Re: [PATCH v3 3/4] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

Maciej W. Rozycki
2020-05-13T22:41:06Z

On Mon, 27 Apr 2020, Nathan Chancellor wrote:

> > Can you actually record in the change description what the difference in
> > the relevant link command is, as shown where `V=1' has been used with
> > `make' invocation?
>
> That will be rather unweildy to put in the commit message since
> currently, $(CC) + $(KBUILD_CFLAGS) is being used but I can if it is
> really desired. Otherwise, I can just put it where I put the changelog.

Umm, is the difference so huge? I think a note along the lines of:

"[...] This change adds/removes[*]:

<part of the command affected>

from the invocation of [...], which is required for [...]"

-- only quoting what's actually changed will be sufficient. Reword as
required. Otherwise it's hard to guess now what the change actually does,
and it will be even harder for someone who comes across it and tries to
understand it the future, when the context might be hard to reproduce.

[*] Delete as appropriate.

Maciej