From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD7CEC54FCF for ; Mon, 20 Apr 2020 04:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC4EA206D4 for ; Mon, 20 Apr 2020 04:52:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="llneVi56" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726061AbgDTEwn (ORCPT ); Mon, 20 Apr 2020 00:52:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgDTEwm (ORCPT ); Mon, 20 Apr 2020 00:52:42 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D45DC061A0C for ; Sun, 19 Apr 2020 21:52:41 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id n16so4467105pgb.7 for ; Sun, 19 Apr 2020 21:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oNKRiUuDH3HcT8/Qwk9sSK+q6T3XdbwZxPtum7dk+0k=; b=llneVi56W55NiLr4/oEdHvQsx+uYbkRQzHPT7RXrZNrdWl4RLJewuv+rVJiKFrxkY4 nmoFjBHPPeFNYEhI0kfaqgQBF6znWdA/EnlSHtnOx4AclT+kIaTuWS5tm4iSecLCnJ2R dooRwMKfMVWt3HMIgWpLAcKKHUSvFmDPybPwq4jo9AkyuK8Dnd4CBBSVaOkqsH7FwfLR s0D/bjS8qTOYDnSracP58KpC0hBcOwJYF3kbiuPScSMwMAdeyIIRIryN1guKVbLzk3eE 1Rl9U9+MmfT//SMqV+TPzyfgxNh7I+SU//n/RgeKQLzsejwKAlcB3D8JTWza3p0o0Svh WsJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oNKRiUuDH3HcT8/Qwk9sSK+q6T3XdbwZxPtum7dk+0k=; b=h7aLeA5AZZoMpGaaQ9MjIg3yIO3zXyLS8q46ACBbvuoxYtqvpXrJ5Vi2CpH4hjAPcQ +ehPMDV8VTt8k3oc2VrTAQeOZ/kplOp9dyNC9utfmXDbDrwfAxJHhjIOlGBFvko+BxhK CZ7ti2MEvkJrCQSmDhXO/j8hxo3kQHkpemtkQMlwMk8gvE+OWko9nLsMeyJ0O5kNWqS4 N4vQVKcN2FunTQpf95yz7tjFTd0fJUvBMGH3f7ralSotz1UWRFmpwtrk00UiQiLxEFgC jdILa27XHb35kC/EWMxUeqIE6+xcq+AZP2ecXjtjcWJgywL3VUgdzdqDpz61VjAlfr2W TJPg== X-Gm-Message-State: AGi0PubtAzrnIMN84EnqtUCNJm0R2M5HXcPwjxJWQDM9qMjWUYSxEG2V A9+SfONjC3Yn6DuDBahDx2fG+QXZy0k= X-Google-Smtp-Source: APiQypL47lTKmGwxOxVtKUAf13H57l0+QHnxWnUbjOkYcpSlzaMu1RjcsaR+CpdIXKiQMYpYBNys4A== X-Received: by 2002:a63:514a:: with SMTP id r10mr12687721pgl.246.1587358360091; Sun, 19 Apr 2020 21:52:40 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id e26sm25908782pfi.84.2020.04.19.21.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2020 21:52:39 -0700 (PDT) Date: Sun, 19 Apr 2020 21:52:37 -0700 From: Bjorn Andersson To: Tang Bin Cc: joro@8bytes.org, agross@kernel.org, robdclark@gmail.com, linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2]iommu/qcom:fix local_base status check Message-ID: <20200420045237.GH987656@yoga> References: <20200418134703.1760-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200418134703.1760-1-tangbin@cmss.chinamobile.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 18 Apr 06:47 PDT 2020, Tang Bin wrote: > The function qcom_iommu_device_probe() does not perform sufficient > error checking after executing devm_ioremap_resource(), which can > result in crashes if a critical error path is encountered. > Thanks, that's much better. Reviewed-by: Bjorn Andersson Regards, Bjorn > Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu") > > Signed-off-by: Tang Bin > --- > v2: > - fix commit message and add fixed tag > --- > drivers/iommu/qcom_iommu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c > index 4328da0b0..b160cf140 100644 > --- a/drivers/iommu/qcom_iommu.c > +++ b/drivers/iommu/qcom_iommu.c > @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev) > qcom_iommu->dev = dev; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (res) > + if (res) { > qcom_iommu->local_base = devm_ioremap_resource(dev, res); > + if (IS_ERR(qcom_iommu->local_base)) > + return PTR_ERR(qcom_iommu->local_base); > + } > > qcom_iommu->iface_clk = devm_clk_get(dev, "iface"); > if (IS_ERR(qcom_iommu->iface_clk)) { > -- > 2.20.1.windows.1 > > >