From: Lee Jones <lee.jones@linaro.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Tang Bin <tangbin@cmss.chinamobile.com>,
Shengju Zhang <zhangshengju@cmss.chinamobile.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: asic3: Add error checking return in asic3_mfd_probe()
Date: Mon, 20 Apr 2020 08:13:39 +0100 [thread overview]
Message-ID: <20200420071339.GG3737@dell> (raw)
In-Reply-To: <b9626e96-4bdb-e7e1-51e7-a99210de4c32@web.de>
On Sun, 19 Apr 2020, Markus Elfring wrote:
> > In the function asic3_mfd_probe(), when get resource or irq
> > failed, the value returned just detected and debug error message,
> > but there were no error checking return. So add the right error
> > checking return.
>
> I suggest to improve the commit message.
> Would you like to adjust the patch subject?
>
>
> > And remove the redundant 'ret = 0'.
>
> I propose to reconsider this interpretation of the source code here.
> How do you think about to move the mentioned statement into an else branch
> at the end?
Could you please fix your mailer.
If you do not, your replies will be lost/discounted!
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-04-20 7:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 11:19 [PATCH] mfd: asic3: Add error checking return in asic3_mfd_probe() Markus Elfring
2020-04-20 7:13 ` Lee Jones [this message]
2020-04-20 8:37 ` Markus Elfring
2020-04-20 8:50 ` Lee Jones
2020-04-20 10:04 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-04-19 9:19 [PATCH] " Tang Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420071339.GG3737@dell \
--to=lee.jones@linaro.org \
--cc=Markus.Elfring@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox