From: Christoph Hellwig <hch@infradead.org>
To: Sidong Yang <realwakka@gmail.com>
Cc: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: qlge: replace deprecated apis pci_dma_*
Date: Mon, 20 Apr 2020 01:48:36 -0700 [thread overview]
Message-ID: <20200420084836.GA24518@infradead.org> (raw)
In-Reply-To: <20200419010816.29125-1-realwakka@gmail.com>
On Sun, Apr 19, 2020 at 10:08:16AM +0900, Sidong Yang wrote:
> direction =
> - (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? PCI_DMA_TODEVICE :
> - PCI_DMA_FROMDEVICE;
> + (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? DMA_TO_DEVICE :
> + DMA_FROM_DEVICE;
Can you unobsfucate this while you are at it?
if (bit & (CFG_LRQ | CFG_LR | CFG_LCQ))
direction = DMA_TO_DEVICE;
else
direction = DMA_FROM_DEVICE;
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-04-20 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 1:08 [PATCH] staging: qlge: replace deprecated apis pci_dma_* Sidong Yang
2020-04-20 8:48 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-20 15:40 Sidong Yang
2020-04-21 8:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420084836.GA24518@infradead.org \
--to=hch@infradead.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox