From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50073C54FCC for ; Mon, 20 Apr 2020 22:52:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20E8821D79 for ; Mon, 20 Apr 2020 22:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587423161; bh=5C7s/qSVaNv2106+z5QfBbJ5HF3obzRVbPhXQwkzMnI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=HqVFMY3eoJB33LoXPpBv4G8vWdvvCMZjB+l5K44v4pCv+nT1YI2MZd/78ovIsKCt+ UN4pp17OS4Prw9M53nL6x7GvE3sd3Po0UL3O/OBqExyuCDnrk5BBuTJ5eIkHMjbHDS 2W5x1NmZdvHwHdCaiXLgIVisbPBBtrONsLdQvziE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbgDTWwk (ORCPT ); Mon, 20 Apr 2020 18:52:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:59362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbgDTWwk (ORCPT ); Mon, 20 Apr 2020 18:52:40 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B5FC218AC; Mon, 20 Apr 2020 22:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587423158; bh=5C7s/qSVaNv2106+z5QfBbJ5HF3obzRVbPhXQwkzMnI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j87CF2BDztq+xDTfNKO0+xDowilpfPtOnTjkrx+LtOU/kJRmOlvqKFfU2pkDF2cDq PhomJCqDYE25XANMzhIWFyaaphzfVSxWWcMREQOzYfuJlGzPlUdtGTVBISLqyCXIt9 RaIzewuD7N8gfFqK/neiGzr1TuIvWosE7DKZ8zHQ= Date: Mon, 20 Apr 2020 15:52:37 -0700 From: Andrew Morton To: Dmitry Safonov Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Greg Kroah-Hartman , Ingo Molnar , Jiri Slaby , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Tetsuo Handa , Rich Felker , linux-sh@vger.kernel.org Subject: Re: [PATCHv3 31/50] sh: Add loglvl to printk_address() Message-Id: <20200420155237.1b6532c0d0c6940fccd1b762@linux-foundation.org> In-Reply-To: <20200418201944.482088-32-dima@arista.com> References: <20200418201944.482088-1-dima@arista.com> <20200418201944.482088-32-dima@arista.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Apr 2020 21:19:25 +0100 Dmitry Safonov wrote: > Currently, the log-level of show_stack() depends on a platform > realization. It creates situations where the headers are printed with > lower log level or higher than the stacktrace (depending on > a platform or user). > > Furthermore, it forces the logic decision from user to an architecture > side. In result, some users as sysrq/kdb/etc are doing tricks with > temporary rising console_loglevel while printing their messages. > And in result it not only may print unwanted messages from other CPUs, > but also omit printing at all in the unlucky case where the printk() > was deferred. > > Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems > an easier approach than introducing more printk buffers. > Also, it will consolidate printings with headers. > > Add log level argument to printk_address() as a preparation to introduce > show_stack_loglvl(). > > As a good side-effect show_fault_oops() now prints the address with > KERN_EMREG as the rest of output, making sure there won't be situation > where "PC: " is printed without actual address. > > --- a/arch/sh/include/asm/kdebug.h > +++ b/arch/sh/include/asm/kdebug.h > @@ -12,7 +12,8 @@ enum die_val { > }; > > /* arch/sh/kernel/dumpstack.c */ > -extern void printk_address(unsigned long address, int reliable); > +extern void printk_address(unsigned long address, int reliable, > + const char *loglvl); > extern void dump_mem(const char *str, const char *loglvl, > unsigned long bottom, unsigned long top); > > ... > > --- a/arch/sh/mm/fault.c > +++ b/arch/sh/mm/fault.c > @@ -196,7 +196,7 @@ show_fault_oops(struct pt_regs *regs, unsigned long address) > > printk(KERN_CONT " at %08lx\n", address); > printk(KERN_ALERT "PC:"); > - printk_address(regs->pc, 1); > + printk_address(regs->pc, 1, KERN_ALERT); > It would be more intuitive to do printk_address(KERN_ALERT, regs->pc, 1); because the loglevel always comes first. I guess it doesn't matter much, as sh seems to be rather dead.