From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dave Airlie <airlied@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Dmitry Safonov <dima@arista.com>,
LKML <linux-kernel@vger.kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
"kernelci.org bot" <bot@kernelci.org>,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty/sysrq: Export sysrq_mask()
Date: Mon, 20 Apr 2020 19:34:51 +0200 [thread overview]
Message-ID: <20200420173451.GA279051@kroah.com> (raw)
In-Reply-To: <CAPM=9tzujQOXo5Df+UZLTW5pp3JNfchSX-0KVZmOidvFQWxkCw@mail.gmail.com>
On Sat, Apr 04, 2020 at 07:53:10AM +1000, Dave Airlie wrote:
> On Thu, 2 Apr 2020 at 11:46, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> > > On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
> > >> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
> > >> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
> > >> >> Build fix for serial_core being module:
> > >> >> ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
> > >> >>
> > >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >> >> Cc: Jiri Slaby <jslaby@suse.com>
> > >> >> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> > >> >> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> > >> >> Signed-off-by: Dmitry Safonov <dima@arista.com>
> > >> >> ---
> > >> >> drivers/tty/sysrq.c | 1 +
> > >> >> 1 file changed, 1 insertion(+)
> > >> >
> > >> > Is this a new problem? What commit does this fix?
> > >>
> > >> Right, sorry I've managed to forget adding the tag:
> > >>
> > >> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
> > >>
> > >> Maybe also:
> > >>
> > >> Link:
> > >> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/
> > >
> > > Thanks, that works. WIll queue this up after -rc1 is out.
> >
> > Why wait until after rc1?
> >
> > It's a build break for a bunch of folks and the fix is obviously correct
> > (famous last words).
>
> definitely seems like something that should be fixed prior to rc1,
> s390 builds in fedora are hitting it.
Ugh, I missed this, I'll go queue this up now, sorry for the delay...
greg k-h
prev parent reply other threads:[~2020-04-20 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 14:39 [PATCH] tty/sysrq: Export sysrq_mask() Dmitry Safonov
2020-04-01 14:46 ` Greg Kroah-Hartman
2020-04-01 14:49 ` Dmitry Safonov
2020-04-01 15:12 ` Greg Kroah-Hartman
2020-04-02 1:45 ` Michael Ellerman
2020-04-03 21:53 ` Dave Airlie
2020-04-20 17:34 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420173451.GA279051@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=0x7f454c46@gmail.com \
--cc=airlied@gmail.com \
--cc=bot@kernelci.org \
--cc=dima@arista.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox