From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48FD9C54FC9 for ; Tue, 21 Apr 2020 07:19:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2442E2098B for ; Tue, 21 Apr 2020 07:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587453548; bh=pCEARRuc1fH9opZ9iz7/AswvNoJgJohYZGGefm4SL1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Q/wqjDQQEP0lsaln4GFszvgmxNq0DzTEVmLlbp3GrA2m79I79Dm8nhl5mFWKsmfOg L8WNwLI3VJ+zrsh0ZIP92XP4ptxoC20n8KpaBRtGQoTxdb6EeIXvQRCRCSDQom4ALa NF1UCHP8teiTK0E19oQnQGW88bx814X3gEB3E/lc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727111AbgDUHTH (ORCPT ); Tue, 21 Apr 2020 03:19:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:35978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbgDUHTG (ORCPT ); Tue, 21 Apr 2020 03:19:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60E422074B; Tue, 21 Apr 2020 07:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587453544; bh=pCEARRuc1fH9opZ9iz7/AswvNoJgJohYZGGefm4SL1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AFnZObskHRCdGYgq54OFuBPUSrXJKr4kGYuvpf4k2qLOspdzFHAdRG4YvfyDygR30 TazJj0OdKHmj3RIvfCeBrVXVmNB+RRqyFseNm4yQY/FMmUyKr/J+5VRINgygZdJEI1 V9sBUqHcakmBRpYm6bQB0HrKOowVgoCmODdyksBI= Date: Tue, 21 Apr 2020 09:19:02 +0200 From: Greg KH To: Evalds Iodzevics Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ben Hutchings Subject: Re: [PATCH v2] x86/microcode/intel: replace sync_core() with native_cpuid_reg(eax) Message-ID: <20200421071902.GA372292@kroah.com> References: <20200420120037.1537-1-evalds.iodzevics@gmail.com> <20200421085344.1804-1-evalds.iodzevics@gmail.com> <20200421055955.GA343434@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 09:41:42AM +0300, Evalds Iodzevics wrote: > On Tue, Apr 21, 2020 at 8:59 AM Greg KH wrote: > > > > On Tue, Apr 21, 2020 at 11:53:44AM +0300, Evalds Iodzevics wrote: > > > On Intel it is required to do CPUID(1) before reading the microcode > > > revision MSR. Current code in 4.4 an 4.9 relies on sync_core() to call > > > CPUID, unfortunately on 32 bit machines code inside sync_core() always > > > jumps past CPUID instruction as it depends on data structure boot_cpu_data > > > witch are not populated correctly so early in boot sequence. > > > > > > It depends on: > > > commit 5dedade6dfa2 ("x86/CPU: Add native CPUID variants returning a single > > > datum") > > > > > > This patch is for 4.4 but also should apply to 4.9 > > > > > > Signed-off-by: Evalds Iodzevics > > > --- > > > arch/x86/include/asm/microcode_intel.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Why are you not sending this to the stable mailing list like I have > > pointed out numerous times by sending you a link to _how_ to get a patch > > into the stable kernel trees? > > > > Again, here it is: > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > Please follow that so that we can do this correctly. > > > > thanks, > > > > greg k-h > Sorry, I might sound dumb here but should i just send it to > stable@vger.kernel.org or try to tag it Cc: stable... in sign-off > area, its quite confusing for newcomer. Yes, be sure to cc: the stable@vger.kernel.org list when you send patches that you want to have applied to a stable kernel tree. thanks, greg k-h