From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: fuse: Update the SoC revision attribute to display a name
Date: Wed, 22 Apr 2020 00:16:06 +0200 [thread overview]
Message-ID: <20200421221606.GD3445172@ulmo> (raw)
In-Reply-To: <20200417124046.26400-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Fri, Apr 17, 2020 at 01:40:46PM +0100, Jon Hunter wrote:
> Currently the SoC revision attribute for Tegra devices displays the
> value of the enum associated with a particular revision. This is not
> very useful because to obtain the actual revision you need to
> use the tegra_revision enumeration to translate the value.
>
> It is more meaningful to display a name for the revision, such as
> 'A01', than the enumarated value and therefore, update the revision
> attribute to display a name. This change does alter the ABI, which
> is unfortunate, but this is more meaningful and maintable.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-04-21 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 12:40 [PATCH] soc/tegra: fuse: Update the SoC revision attribute to display a name Jon Hunter
2020-04-21 22:16 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421221606.GD3445172@ulmo \
--to=thierry.reding@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox