From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E5D2C55186 for ; Wed, 22 Apr 2020 10:17:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE6BE2075A for ; Wed, 22 Apr 2020 10:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550659; bh=HA6+GC89rafwWNBKzZMz9dvrNvatJ3whB4WkyWT57a8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o4/y37jNDOnb+IbfQ+rwNUho/BvZ0UuaxehMJMkh3q4HR6GoBWI6m3RxoYgGK6mQc JPdMdL4ZJ2tjeMOgoLXZ7pYkT4WwmsmIBfZ2Pch6oRlOJU7GCWT5ZP8AGn7WWwl/5y vurCbZPWA29n8w3lAC37gScfHKwTH6TzVU24jSyI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729860AbgDVKRi (ORCPT ); Wed, 22 Apr 2020 06:17:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:52354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729189AbgDVKQd (ORCPT ); Wed, 22 Apr 2020 06:16:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1FB12070B; Wed, 22 Apr 2020 10:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550593; bh=HA6+GC89rafwWNBKzZMz9dvrNvatJ3whB4WkyWT57a8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tasJydlYVxgxeIA7JEXg2kkSwa52GZN7dToxLhSY7VKNupL9y8GJGuMFKteIXYysO VZuMPa/OEgeJ5MPNi4Cp4Id2pOXkNVHadvlz8Yh5FVVGmeTHc5vnQfYNqhzL7qo5Fd NuWap7HolMM1ZgiBsOKw1/YM4WWv75O//1aZxCQ8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Erhard F." , Frank Rowand , Rob Herring Subject: [PATCH 5.4 015/118] of: unittest: kmemleak on changeset destroy Date: Wed, 22 Apr 2020 11:56:16 +0200 Message-Id: <20200422095034.058524447@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095031.522502705@linuxfoundation.org> References: <20200422095031.522502705@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand commit b3fb36ed694b05738d45218ea72cf7feb10ce2b1 upstream. kmemleak reports several memory leaks from devicetree unittest. This is the fix for problem 1 of 5. of_unittest_changeset() reaches deeply into the dynamic devicetree functions. Several nodes were left with an elevated reference count and thus were not properly cleaned up. Fix the reference counts so that the memory will be freed. Fixes: 201c910bd689 ("of: Transactional DT support.") Reported-by: Erhard F. Signed-off-by: Frank Rowand Signed-off-by: Rob Herring Signed-off-by: Greg Kroah-Hartman --- drivers/of/unittest.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -776,6 +776,10 @@ static void __init of_unittest_changeset unittest(!of_changeset_revert(&chgset), "revert failed\n"); of_changeset_destroy(&chgset); + + of_node_put(n1); + of_node_put(n2); + of_node_put(n21); #endif }