From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980B2C55185 for ; Wed, 22 Apr 2020 11:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7216E20784 for ; Wed, 22 Apr 2020 11:29:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="aLZ9ofho" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbgDVL3d (ORCPT ); Wed, 22 Apr 2020 07:29:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726747AbgDVL31 (ORCPT ); Wed, 22 Apr 2020 07:29:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D25C03C1A8 for ; Wed, 22 Apr 2020 04:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-Id:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=ENpewQeaQGUGDSg9de8TRoTBBnJpselPl76x594xnb4=; b=aLZ9ofhoOVs0MgNSzPxNsWisMS Q1prIv29KECuBYIbY46nOMnNvrQlEdW5AaFZXIjuLPKZEFVgOfvlgf3g3S9fQ7bQBEc4IAKvHkERm Wu2KXEIxNxm3Iy+8dFDavIz+KwD5K18cyegbsC3GCZThXQXQ98sOZ6C1DhHZUchklOoHUpeO85p2g YveONVi1jiB2HjBvFN7MA6sZ6qqnFsVABgy3TaAhY+v9yI3uYFyLdz8ytAkym87NuHe4D+ZoOUXpc p4IeAjxmdFYyT9BHeHmyuIrEsRh2HzwQ5IKtNzZ7kMw9GN+V/qCf5HS/n/acjbTVpvCc4fe5mqB0n nqO3i4aA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRDYx-0003ax-63; Wed, 22 Apr 2020 11:29:07 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 381C6307957; Wed, 22 Apr 2020 13:29:03 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id CF802200C9CB7; Wed, 22 Apr 2020 13:29:02 +0200 (CEST) Message-Id: <20200422112831.692776147@infradead.org> User-Agent: quilt/0.65 Date: Wed, 22 Apr 2020 13:27:27 +0200 From: Peter Zijlstra To: mingo@kernel.org, linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, rostedt@goodmis.org, qais.yousef@arm.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, peterz@infradead.org, alexander.deucher@amd.com Subject: [PATCH 08/23] sched,drm/scheduler: Convert to sched_set_fifo*() References: <20200422112719.826676174@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because SCHED_FIFO is a broken scheduler model (see previous patches) take away the priority field, the kernel can't possibly make an informed decision. In this case, use fifo_low, because it only cares about being above SCHED_NORMAL. Effectively no change in behaviour. Cc: alexander.deucher@amd.com Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Ingo Molnar --- drivers/gpu/drm/scheduler/sched_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -760,11 +760,10 @@ static bool drm_sched_blocked(struct drm */ static int drm_sched_main(void *param) { - struct sched_param sparam = {.sched_priority = 1}; struct drm_gpu_scheduler *sched = (struct drm_gpu_scheduler *)param; int r; - sched_setscheduler(current, SCHED_FIFO, &sparam); + sched_set_fifo_low(current); while (!kthread_should_stop()) { struct drm_sched_entity *entity = NULL;