From: Jessica Yu <jeyu@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v2] arch: split MODULE_ARCH_VERMAGIC definitions out to <asm/vermagic.h>
Date: Wed, 22 Apr 2020 15:17:29 +0200 [thread overview]
Message-ID: <20200422131729.GB20103@linux-8ccs> (raw)
In-Reply-To: <20200421161355.1357112-1-masahiroy@kernel.org>
+++ Masahiro Yamada [22/04/20 01:13 +0900]:
[snip]
>diff --git a/arch/xtensa/include/asm/module.h b/arch/xtensa/include/asm/vermagic.h
>similarity index 72%
>rename from arch/xtensa/include/asm/module.h
>rename to arch/xtensa/include/asm/vermagic.h
>index 488b40c6f9b9..6f9e359a54ac 100644
>--- a/arch/xtensa/include/asm/module.h
>+++ b/arch/xtensa/include/asm/vermagic.h
>@@ -1,6 +1,4 @@
> /*
>- * include/asm-xtensa/module.h
>- *
> * This file contains the module code specific to the Xtensa architecture.
Maybe we can remove this comment too? Since it's now asm/vermagic.h and
not asm/module.h anymore.
Thanks for the cleanup. I agree that <linux/vermagic.h> shouldn't have
any ordering dependency on <linux/module.h>.
I just double checked to see if there were any other users of
MODULE_ARCH_VERMAGIC that needed it through module.h, and there are
none. It was literally just being defined in asm/module.h to be used
in linux/vermagic.h. So there was no reason really to confine the
MODULE_ARCH_VERMAGIC definition to asm/module.h.
Acked-by: Jessica Yu <jeyu@kernel.org>
next prev parent reply other threads:[~2020-04-22 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 16:13 [PATCH v2] arch: split MODULE_ARCH_VERMAGIC definitions out to <asm/vermagic.h> Masahiro Yamada
2020-04-22 13:17 ` Jessica Yu [this message]
2020-04-22 16:06 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422131729.GB20103@linux-8ccs \
--to=jeyu@kernel.org \
--cc=bp@suse.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox