From: Andrew Lunn <andrew@lunn.ch>
To: Jakov Petrina <jakov.petrina@sartura.hr>
Cc: jason@lakedaemon.net, devicetree@vger.kernel.org,
gregory.clement@bootlin.com, linux-kernel@vger.kernel.org,
vladimir.vid@sartura.hr, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com,
Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
Date: Wed, 22 Apr 2020 17:24:39 +0200 [thread overview]
Message-ID: <20200422152439.GG974925@lunn.ch> (raw)
In-Reply-To: <20200422150915.3355073-1-jakov.petrina@sartura.hr>
On Wed, Apr 22, 2020 at 05:09:15PM +0200, Jakov Petrina wrote:
> This resolves issues with certain SPF modules.
Hi Jakov
Please could you explain this some more. PHYLINK should be setting the
mode appropriately, based on the capabilities of the SFP module. Is
the real problem that the SFP module is indicating the wrong baud
rate?
Andrew
>
> Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
> Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> index 7eb6c1796cef..b6e2a9c68b2a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -144,7 +144,7 @@ lm75@49 {
> };
>
> ð0 {
> - phy-mode = "sgmii";
> + phy-mode = "2500base-x";
> status = "okay";
> managed = "in-band-status";
> phys = <&comphy1 0>;
> @@ -152,7 +152,7 @@ ð0 {
> };
>
> ð1 {
> - phy-mode = "sgmii";
> + phy-mode = "2500base-x";
> status = "okay";
> managed = "in-band-status";
> phys = <&comphy0 1>;
> --
> 2.24.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-22 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:09 [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x Jakov Petrina
2020-04-22 15:24 ` Andrew Lunn [this message]
2020-04-22 15:37 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422152439.GG974925@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jakov.petrina@sartura.hr \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vladimir.vid@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox