Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

Krzysztof Kozlowski
2020-04-15T12:03:28Z

On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> From: Jonathan Bakker <xc-racer2@live.ca>
>
> to add support for SGX540 GPU.

Do not continue the subject in commit msg like it is one sentence.
These are two separate sentences, so commit msg starts with capital
letter and it is sentence by itself.

> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 2ad642f51fd9..e7fc709c0cca 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 {
> #interrupt-cells = <1>;
> };
>
> + g3d: g3d@f3000000 {
> + compatible = "samsung,s5pv210-sgx540-120";
> + reg = <0xf3000000 0x10000>;
> + interrupt-parent = <&vic2>;
> + interrupts = <10>;
> + clock-names = "sclk";
> + clocks = <&clocks CLK_G3D>;

Not part of bindings, please remove or add to the bindings.

> +
> + power-domains = <&pd S5PV210_PD_G3D>;

Ditto

> +
> + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>;
> + assigned-clock-rates = <0>, <66700000>;
> + assigned-clock-parents = <&clocks MOUT_MPLL>;

Probably this should have status disabled because you do not set
regulator supply.

Best regards,
Krzysztof