Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node

H. Nikolaus Schaller
2020-04-15T14:08:05Z

> Am 15.04.2020 um 15:47 schrieb Krzysztof Kozlowski <krzk@kernel.org>:
>
> On Wed, Apr 15, 2020 at 01:46:06PM +0200, H. Nikolaus Schaller wrote:
>> Hi Krzysztof,
>>
>>> Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski <krzk@kernel.org>:
>>>
>>> On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller <hns@goldelico.com> wrote:
>>>>
>>>> and add interrupt.
>>>>
>>>> Tested-by: H. Nikolaus Schaller <hns@goldelico.com> # Pyra-Handheld.
>>>
>>> Don't add your own Tested-by tags. These are implied by authorship,
>>> otherwise all patches people make should have such tag.
>>
>> Ok I see. AFAIR it originates in several phases of editing to report on which device it was tested.
>>
>> Is there a canonical way of writing "tested-on: ${HARDWARE}"?
>>
>> E.g. would this be ok?
>>
>> Signed-off: H. Nikolaus Schaller <hns@goldelico.com> # tested on Pyra-Handheld
>
> If you think tested platform is worth mentioning in the commit msg
> (it will stay there forever, ever, ever) then just add a line like:
>
> "Add SGX GPU node. Tested on Pyra-Handheld."
>
> From time to time we add such information to note that only one platform
> was actually tested.

Yes that is what it should express.

> I am not sure what benefit it brings to most
> cases... but your commit msg is so short that adding one more sentence
> seems reasonable. :)

Ok, will queue for v7.

>
> Best regards,
> Krzysztof

BR and thanks,
Nikolaus