Re: [PATCH v2 01/11] perf expr: unlimited escaped characters in a symbol

kajoljain
2020-04-27T09:31:52Z

On 4/23/20 4:59 PM, Jiri Olsa wrote:
> On Wed, Apr 22, 2020 at 03:04:20PM -0700, Ian Rogers wrote:
>> Current expression allows 2 escaped '-,=' characters. However, some
>> metrics require more, for example Haswell DRAM_BW_Use.
>>
>> Fixes: 26226a97724d (perf expr: Move expr lexer to flex)
>> Signed-off-by: Ian Rogers <irogers@google.com>
>> ---
>> tools/perf/util/expr.l | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/expr.l b/tools/perf/util/expr.l
>> index 2582c2464938..95bcf3629edf 100644
>> --- a/tools/perf/util/expr.l
>> +++ b/tools/perf/util/expr.l
>> @@ -73,7 +73,7 @@ number [0-9]+
>> sch [-,=]
>> spec \\{sch}
>> sym [0-9a-zA-Z_\.:@]+
>> -symbol {spec}*{sym}*{spec}*{sym}*
>> +symbol ({spec}|{sym})+

Tested by: kjain@linux.ibm.com

Thanks,
Kajol Jain
>
> yep, much better ;-)
>
> thanks,
> jirka
>
>>
>> %%
>> struct expr_scanner_ctx *sctx = expr_get_extra(yyscanner);
>> --
>> 2.26.2.303.gf8c07b1a785-goog
>>
>