From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61805C54FCB for ; Thu, 23 Apr 2020 11:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 390AE2077D for ; Thu, 23 Apr 2020 11:29:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IeUWeQon" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728161AbgDWL3y (ORCPT ); Thu, 23 Apr 2020 07:29:54 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:59574 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728035AbgDWL3x (ORCPT ); Thu, 23 Apr 2020 07:29:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587641392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=roA7oSvUwqVq7fxAgKiqFkL2qs0oAGhgEsm3N0YXn9U=; b=IeUWeQonc+pzmtYVeRHN8aLBvfymy8WSw4BKCZo1dxqUYlrEHH98U/6L/QmA63hVIswt34 3D4fciOkBPHTK4a9T+qOD2+QSrUa39XaH05CsHDk5mvx23EOfbM0JlYY3jMkvW3Q4//T5P yUF4DSge7JuQtZK28YzxbckoOi9WvPw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-MCck4-NpMmWwMxhf2xtErA-1; Thu, 23 Apr 2020 07:29:48 -0400 X-MC-Unique: MCck4-NpMmWwMxhf2xtErA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F939800C78; Thu, 23 Apr 2020 11:29:45 +0000 (UTC) Received: from krava (unknown [10.40.196.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A507D5D710; Thu, 23 Apr 2020 11:29:41 +0000 (UTC) Date: Thu, 23 Apr 2020 13:29:39 +0200 From: Jiri Olsa To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Kan Liang , Andi Kleen , Haiyan Song , Jin Yao , Song Liu , Ravi Bangoria , John Garry , Leo Yan , Adrian Hunter , Paul Clarke , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v2 04/11] perf expr: allow ',' to be an other token Message-ID: <20200423112939.GJ1136647@krava> References: <20200422220430.254014-1-irogers@google.com> <20200422220430.254014-5-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422220430.254014-5-irogers@google.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 03:04:23PM -0700, Ian Rogers wrote: > Corrects parse errors in expr__find_other of expressions with min. > > Signed-off-by: Ian Rogers > --- > tools/perf/util/expr.y | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y > index cd17486c1c5d..54260094b947 100644 > --- a/tools/perf/util/expr.y > +++ b/tools/perf/util/expr.y > @@ -80,7 +80,7 @@ other: ID > ctx->ids[ctx->num_ids++].name = $1; > } > | > -MIN | MAX | IF | ELSE | SMT_ON | NUMBER | '|' | '^' | '&' | '-' | '+' | '*' | '/' | '%' | '(' | ')' > +MIN | MAX | IF | ELSE | SMT_ON | NUMBER | '|' | '^' | '&' | '-' | '+' | '*' | '/' | '%' | '(' | ')' | ',' ugh, thanks jirka > > > all_expr: if_expr { *final_val = $1; } > -- > 2.26.2.303.gf8c07b1a785-goog >