From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E0DC54FCB for ; Thu, 23 Apr 2020 11:40:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 704D820857 for ; Thu, 23 Apr 2020 11:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587642036; bh=v+cZbNEq+8xq9TdljfKBzmW0OSxSI3Wv8ELxe4MyXrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sl1iGje0Kr/Mc3Zqyap2vICmddoF9YunYtzcFcXlf4pNXAN4JEfy3BgV7VsK+Naov kz/FcXTJaaZLqb0wOay48fSu5J0PBRDLrhJQMMJWXllr0CBrKXFA/iABBDPjIWFxlu lCORFI00kInuIvYT6h4HFK5vHssL5TrvSOR+pu6s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728096AbgDWLkf (ORCPT ); Thu, 23 Apr 2020 07:40:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:52532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727903AbgDWLkf (ORCPT ); Thu, 23 Apr 2020 07:40:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 716EC2084D; Thu, 23 Apr 2020 11:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587642034; bh=v+cZbNEq+8xq9TdljfKBzmW0OSxSI3Wv8ELxe4MyXrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sBJms3bpeviFauiUcUCQiOq4YvvYk8OFWsy6Mp3B3HOj2vHhfIUOdLNK6VE7XTw/v 0ouOwtoiVcQZBwXoRq0gVUDPF5lCTPzp00Kx+NssOTIojVr14VSLr5B6qEeEIXo/Co PVQZ5gxk+pxMcaBUiQjn3KKxoZiOVne9eWvObe4I= Date: Thu, 23 Apr 2020 13:40:32 +0200 From: Greg Kroah-Hartman To: Oscar Carter Cc: Forest Bond , Quentin Deslandes , Malcolm Priestley , Amir Mahdi Ghorbanian , Stefano Brivio , "John B. Wyatt IV" , Colin Ian King , Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: vt6656: Check the return value of vnt_control_out_* calls Message-ID: <20200423114032.GA3838948@kroah.com> References: <20200419104821.6127-1-oscar.carter@gmx.com> <20200419104821.6127-2-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200419104821.6127-2-oscar.carter@gmx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 19, 2020 at 12:48:20PM +0200, Oscar Carter wrote: > Check the return value of vnt_control_out_* function calls. When > necessary modify the function prototype to be able to return the new > checked error code. > > It's safe to modify all the function prototypes without fix the call > because the only change is the return value from void to int. If before > the call didn't check the return value, now neither. > > Signed-off-by: Oscar Carter This patch, and the 2/2 patch did not apply to my tree. Can you please rebase and resend? thanks, greg k-h