From: Dejin Zheng <zhengdejin5@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
virtualization@lists.linux-foundation.org,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] drm/bochs: fix an issue of ioremap() leak
Date: Thu, 23 Apr 2020 22:14:16 +0800 [thread overview]
Message-ID: <20200423141416.GA1562@nuc8i5> (raw)
In-Reply-To: <20200423101420.ityynrorrehjvxrs@sirius.home.kraxel.org>
On Thu, Apr 23, 2020 at 12:14:20PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > I am a newbie, andy gave me some directions to submit the patch, eg: check
> > ioremap leak. At this time, I found that the bochs driver may have similar
> > problems, so I submitted this patch, then, Andy said the best is to switch
> > this driver to use pcim _ * () functions and drop tons of legacy code.
> > I think we might be able to fix this issue first, after that, drop tons
> > of legacy code by pcim_*() functions. Can you give me some suggestions?
> > thank you very much!
>
> drm has drmm_* functions for that. Daniel Vetter <daniel@ffwll.ch> has
> a patch series pending switching lots of drivers over and IIRC it fixes
> this bug too.
>
Gerd, Thanks for your info and abandon this commit.
BR,
Dejin
> cheers,
> Gerd
>
prev parent reply other threads:[~2020-04-23 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 16:45 [PATCH v1] drm/bochs: fix an issue of ioremap() leak Dejin Zheng
2020-04-21 17:24 ` Andy Shevchenko
2020-04-22 13:52 ` Dejin Zheng
2020-04-22 14:40 ` Andy Shevchenko
2020-04-22 15:21 ` Dejin Zheng
2020-04-23 10:14 ` Gerd Hoffmann
2020-04-23 14:14 ` Dejin Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423141416.GA1562@nuc8i5 \
--to=zhengdejin5@gmail.com \
--cc=airlied@linux.ie \
--cc=andy.shevchenko@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox