Re: [PATCH RFC 01/15] drivers/base: Introduce platform_msi_ops

Greg KH
2020-04-26T07:01:23Z

On Tue, Apr 21, 2020 at 04:33:53PM -0700, Dave Jiang wrote:
> From: Megha Dey <megha.dey@linux.intel.com>
>
> This is a preparatory patch to introduce Interrupt Message Store (IMS).
>
> Until now, platform-msi.c provided a generic way to handle non-PCI MSI
> interrupts. Platform-msi uses its parent chip's mask/unmask routines
> and only provides a way to write the message in the generating device.
>
> Newly creeping non-PCI complaint MSI-like interrupts (Intel's IMS for
> instance) might need to provide a device specific mask and unmask callback
> as well, apart from the write function.
>
> Hence, introduce a new structure platform_msi_ops, which would provide
> device specific write function as well as other device specific callbacks
> (mask/unmask).
>
> Signed-off-by: Megha Dey <megha.dey@linux.intel.com>

As this is not following the Intel-specific rules for sending me new
code, I am just deleting it all from my inbox.

Please follow the rules you all have been given, they are specific and
there for a reason. And in looking at this code, those rules are not
going away any time soon.

greg k-h