From: Borislav Petkov <bp@alien8.de>
To: Jason Yan <yanaijie@huawei.com>
Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rrichter@marvell.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] EDAC: remove defined but not used 'bridge_str'
Date: Fri, 24 Apr 2020 09:31:42 +0200 [thread overview]
Message-ID: <20200424073142.GA17202@zn.tnic> (raw)
In-Reply-To: <20200415085006.6732-1-yanaijie@huawei.com>
On Wed, Apr 15, 2020 at 04:50:06PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/edac/amd8131_edac.c:47:21: warning: ‘bridge_str’ defined but not
> used [-Wunused-const-variable=]
> static char * const bridge_str[] = {
> ^~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/edac/amd8131_edac.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
> index 93c82bc17493..169353710982 100644
> --- a/drivers/edac/amd8131_edac.c
> +++ b/drivers/edac/amd8131_edac.c
> @@ -44,14 +44,6 @@ static void edac_pci_write_dword(struct pci_dev *dev, int reg, u32 val32)
> " PCI Access Write Error at 0x%x\n", reg);
> }
>
> -static char * const bridge_str[] = {
> - [NORTH_A] = "NORTH A",
> - [NORTH_B] = "NORTH B",
> - [SOUTH_A] = "SOUTH A",
> - [SOUTH_B] = "SOUTH B",
> - [NO_BRIDGE] = "NO BRIDGE",
> -};
> -
> /* Support up to two AMD8131 chipsets on a platform */
> static struct amd8131_dev_info amd8131_devices[] = {
> {
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-04-24 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:50 [PATCH] EDAC: remove defined but not used 'bridge_str' Jason Yan
2020-04-15 21:19 ` Robert Richter
2020-04-24 7:31 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424073142.GA17202@zn.tnic \
--to=bp@alien8.de \
--cc=hulkci@huawei.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox