From: Wolfram Sang <wsa@the-dreams.de>
To: "Björn Ardö" <bjorn.ardo@axis.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
patrick@stwcx.xyz, kernel@axis.com
Subject: Re: [PATCHv2] i2c: slave-eeprom: Make it possible to pre-load eeprom data
Date: Fri, 24 Apr 2020 13:13:37 +0200 [thread overview]
Message-ID: <20200424111337.GC1959@kunai> (raw)
In-Reply-To: <20200424090443.26316-1-bjorn.ardo@axis.com>
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
On second look, two questions:
> + if (!error) {
> + int ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev,
> + eeprom->buffer, size);
> + if (ret)
> + return ret;
Aren't we leaking 'fw' here?
Also, do we need 'error' and 'ret'? Can't we reuse one of them?
> + release_firmware(fw);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-24 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:04 [PATCHv2] i2c: slave-eeprom: Make it possible to pre-load eeprom data Björn Ardö
2020-04-24 10:03 ` Wolfram Sang
2020-04-24 10:06 ` Bjorn Ardo
2020-04-24 15:32 ` Patrick Williams
2020-04-24 11:13 ` Wolfram Sang [this message]
2020-04-24 11:22 ` Bjorn Ardo
2020-04-24 11:27 ` Wolfram Sang
2020-04-24 11:31 ` Bjorn Ardo
-- strict thread matches above, loose matches on Subject: below --
2020-04-24 11:29 Björn Ardö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424111337.GC1959@kunai \
--to=wsa@the-dreams.de \
--cc=bjorn.ardo@axis.com \
--cc=kernel@axis.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox