From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACF9C54FCB for ; Fri, 24 Apr 2020 12:26:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDC0C20767 for ; Fri, 24 Apr 2020 12:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731164; bh=OEI2R7+enJOr2IEcMB4Te9qDBFNBaSxgakT36s5/Vl0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iNACqJwj7/3ZGqTOxcfUyduFPBmXEYahwyeWJ9Rjzjwse2MDozMt48Ox4D0btKZmG zo+EPEqPIo5L58GyDss1EmZaE41mWJk2Bg5svBqk5l0htbmEJRu1gWTp9OF7VAOfUC XNxPjQXCBnOS7UNTvWpoGb+ozYwg9TcFgVeMUKio= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727995AbgDXM0D (ORCPT ); Fri, 24 Apr 2020 08:26:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:56016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728614AbgDXMZB (ORCPT ); Fri, 24 Apr 2020 08:25:01 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B35B21655; Fri, 24 Apr 2020 12:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731101; bh=OEI2R7+enJOr2IEcMB4Te9qDBFNBaSxgakT36s5/Vl0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=brpbhhRn3ih6sEYy222GBZ3PRI0F+5SVaL0mwAI9hSy1+FOG93P6Hg2QtlKP++jh3 LFiJ7iPKlC+1OBIHyTShcr9NdIzKMAdPy/Y7SI+x+yDN0SsLBq7Ydb9cU+FPE7Vm4e R6BJRQ7PI0hf2WH4KquSU7E0jlVpwaoM0w/z5/QU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Frank Rowand , "Erhard F ." , Rob Herring , Sasha Levin , devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 12/13] of: unittest: kmemleak on changeset destroy Date: Fri, 24 Apr 2020 08:24:45 -0400 Message-Id: <20200424122447.10882-12-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200424122447.10882-1-sashal@kernel.org> References: <20200424122447.10882-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand [ Upstream commit b3fb36ed694b05738d45218ea72cf7feb10ce2b1 ] kmemleak reports several memory leaks from devicetree unittest. This is the fix for problem 1 of 5. of_unittest_changeset() reaches deeply into the dynamic devicetree functions. Several nodes were left with an elevated reference count and thus were not properly cleaned up. Fix the reference counts so that the memory will be freed. Fixes: 201c910bd689 ("of: Transactional DT support.") Reported-by: Erhard F. Signed-off-by: Frank Rowand Signed-off-by: Rob Herring Signed-off-by: Sasha Levin --- drivers/of/unittest.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 92530525e3556..40d170c1ecd50 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -539,6 +539,10 @@ static void __init of_unittest_changeset(void) unittest(!of_changeset_revert(&chgset), "revert failed\n"); of_changeset_destroy(&chgset); + + of_node_put(n1); + of_node_put(n2); + of_node_put(n21); #endif } -- 2.20.1