From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B003C2BA1A for ; Fri, 24 Apr 2020 23:58:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40B212075D for ; Fri, 24 Apr 2020 23:58:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726138AbgDXX6g (ORCPT ); Fri, 24 Apr 2020 19:58:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:54796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgDXX6g (ORCPT ); Fri, 24 Apr 2020 19:58:36 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A98F20748; Fri, 24 Apr 2020 23:58:35 +0000 (UTC) Date: Fri, 24 Apr 2020 19:58:33 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Borislav Petkov , Kees Cook , LKML , Ingo Molnar , Andrew Morton Subject: Re: [BUGFIX PATCH 1/1] bootconfig: Fix to remove bootconfig data from initrd while boot Message-ID: <20200424195833.1487a1a0@oasis.local.home> In-Reply-To: <158774605193.7423.573803007569761807.stgit@devnote2> References: <158774604073.7423.11492815214537711118.stgit@devnote2> <158774605193.7423.573803007569761807.stgit@devnote2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Apr 2020 01:34:12 +0900 Masami Hiramatsu wrote: > If there is a bootconfig data in the tail of initrd/initramfs, > initrd image sanity check caused an error while decompression > stage as follows. > > [ 0.883882] Unpacking initramfs... > [ 2.696429] Initramfs unpacking failed: invalid magic at start of compressed archive > > This error will be ignored if CONFIG_BLK_DEV_RAM=n, > but CONFIG_BLK_DEV_RAM=y the kernel failed to mount rootfs > and causes a panic. > > To fix this issue, shrink down the initrd_end for removing > tailing bootconfig data while boot the kernel. > > Fixes: 7684b8582c24 ("bootconfig: Load boot config from the tail of initrd") > Signed-off-by: Masami Hiramatsu > Cc: stable@vger.kernel.org > --- > init/main.c | 62 +++++++++++++++++++++++++++++++++++++++++++---------------- > 1 file changed, 45 insertions(+), 17 deletions(-) > > A build with $ make allnoconfig Produces this: MODPOST vmlinux.o MODINFO modules.builtin.modinfo GEN modules.builtin LD vmlinux ld: init/main.o: in function `start_kernel': main.c:(.init.text+0x37f): undefined reference to `initrd_end' ld: main.c:(.init.text+0x3a7): undefined reference to `initrd_start' ld: main.c:(.init.text+0x3ae): undefined reference to `initrd_end' make[1]: *** [/work/git/linux-trace.git/Makefile:1106: vmlinux] Error 1 -- Steve