From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B1BC54FCB for ; Sat, 25 Apr 2020 17:01:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B4EF20700 for ; Sat, 25 Apr 2020 17:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587834076; bh=gt3fpYTkrKObtHXD/pWODA9eL7Nil3GW9E4wiPFnZsI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=lHVkLGkt9Nv5FpTmaFmc3pFwTlYXftXPXZORN4lP68Gr9g4HmOgGV3EnLZ1p8Eu6c f2WHXXaseP7dyQ2zrO39l4g/bYpyn7R7MrT7dUpn0Oh2cadL+j/anCW0sOgeDKaiJ6 CBy1qi4b63IuIopD6Y8Ah7mLCbwX/CjZjJbVGncU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgDYRBP (ORCPT ); Sat, 25 Apr 2020 13:01:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:40484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgDYRBP (ORCPT ); Sat, 25 Apr 2020 13:01:15 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23B9B206B6; Sat, 25 Apr 2020 17:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587834074; bh=gt3fpYTkrKObtHXD/pWODA9eL7Nil3GW9E4wiPFnZsI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=elUDhyeGLpVAWIboxfI9gncmA3dQ/XCSrHFj4TQaq7iWRdfwCJzVmiQCEnyxxrcIS fRIAfxI//TPr0jppQtXhM5ubHSKY+QXfNFYCyfBxyI7oZGoIQXWJ32Pcae8OiMmBnW ufVvh9hdock4NsfDcooY+NIDw6qnbV8bCuayk8pQ= Date: Sat, 25 Apr 2020 18:01:10 +0100 From: Jonathan Cameron To: "Ardelean, Alexandru" Cc: "lars@metafoo.de" , "linux-iio@vger.kernel.org" , "Bogdan, Dragos" , "pmeerw@pmeerw.net" , "knaack.h@gmx.de" , "colin.king@canonical.com" , "Hennerich, Michael" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][next] iio: adc: ad7476: remove redundant null check on an array Message-ID: <20200425180110.3ffa5696@archlinux> In-Reply-To: References: <20200424130419.22940-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Apr 2020 15:01:26 +0000 "Ardelean, Alexandru" wrote: > On Fri, 2020-04-24 at 14:04 +0100, Colin King wrote: > > From: Colin Ian King > > > > The null check on st->chip_info->convst_channel is redundant because > > convst_channel is a 2 element array of struct iio_chan_spec objects > > and this can never be null. Fix this by removing the null check. > > > > Reviewed-by: Alexandru Ardelean Applied to the togreg branch of iio.git and pushed out as testing. I didn't take this as a fix as it's not doing any harm in the meantime whilst this patch goes the slow route. Thanks, Jonathan > > > Addresses-Coverity: ("Array compared against 0") > > Signed-off-by: Colin Ian King > > --- > > drivers/iio/adc/ad7476.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c > > index e9984a38fc4c..4e816d714ad2 100644 > > --- a/drivers/iio/adc/ad7476.c > > +++ b/drivers/iio/adc/ad7476.c > > @@ -309,7 +309,7 @@ static int ad7476_probe(struct spi_device *spi) > > indio_dev->num_channels = 2; > > indio_dev->info = &ad7476_info; > > > > - if (st->convst_gpio && st->chip_info->convst_channel) > > + if (st->convst_gpio) > > indio_dev->channels = st->chip_info->convst_channel; > > /* Setup default message */ > >