From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3D9C54FCB for ; Sat, 25 Apr 2020 19:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9970A20714 for ; Sat, 25 Apr 2020 19:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587842978; bh=2jp3t7QXeUX3mIgHp2d/HsdvcvVVVv4RrbuFM7eI1vE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=wrV24go0Beewz1OXd1TD8OkZt9ktjHcjUpvRyqkb3m9W5U8EkuLKf+cl5odwssdAr wZK//9/eC59SdPifdIf721CArFIvUnHOF6MBcaRO4om90GLx4uCupcIaOMnRPt0A2s +LCXct8vJMLGq1YrZe4u9Op32LRzA85l4bM6wscQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbgDYT3h (ORCPT ); Sat, 25 Apr 2020 15:29:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:43026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgDYT3h (ORCPT ); Sat, 25 Apr 2020 15:29:37 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F10E0206D4; Sat, 25 Apr 2020 19:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587842976; bh=2jp3t7QXeUX3mIgHp2d/HsdvcvVVVv4RrbuFM7eI1vE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tpdMYXSHX/jTmct04NI6/pPwCxE99EDOwmXUOHY8UmNChwePb5PgGycckABIkglyG Yi3kmsJTiL74rtlKyvxoCP5mmIc/NUxSE00DEBB03EjbzOvO2dXtEZeecJ9Zr5X/SF pF65nt6JW211C8PG8zqixpX6e9Y0jxNdnyTAJLrw= Date: Sat, 25 Apr 2020 20:29:32 +0100 From: Jonathan Cameron To: Heiko Stuebner Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, xxm@rock-chips.com, kever.yang@rock-chips.com, Heiko Stuebner Subject: Re: [PATCH v5 2/3] iio: adc: rockchip_saradc: better prefix for channel constant Message-ID: <20200425202932.364ae11e@archlinux> In-Reply-To: <20200419100207.58108-2-heiko@sntech.de> References: <20200419100207.58108-1-heiko@sntech.de> <20200419100207.58108-2-heiko@sntech.de> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Apr 2020 12:02:06 +0200 Heiko Stuebner wrote: > From: Heiko Stuebner > > As suggested give the current ADC_CHANNEL constant a distinct > and consistent prefix. > > Suggested-by: Peter Meerwald-Stadler > Signed-off-by: Heiko Stuebner Good change. I'll pick up once the rest of the series is ready. Jonathan > --- > changes in v5: > - new patch > > drivers/iio/adc/rockchip_saradc.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > index 270eb7e83823..29d7f6e4057e 100644 > --- a/drivers/iio/adc/rockchip_saradc.c > +++ b/drivers/iio/adc/rockchip_saradc.c > @@ -118,7 +118,7 @@ static const struct iio_info rockchip_saradc_iio_info = { > .read_raw = rockchip_saradc_read_raw, > }; > > -#define ADC_CHANNEL(_index, _id) { \ > +#define SARADC_CHANNEL(_index, _id) { \ > .type = IIO_VOLTAGE, \ > .indexed = 1, \ > .channel = _index, \ > @@ -128,9 +128,9 @@ static const struct iio_info rockchip_saradc_iio_info = { > } > > static const struct iio_chan_spec rockchip_saradc_iio_channels[] = { > - ADC_CHANNEL(0, "adc0"), > - ADC_CHANNEL(1, "adc1"), > - ADC_CHANNEL(2, "adc2"), > + SARADC_CHANNEL(0, "adc0"), > + SARADC_CHANNEL(1, "adc1"), > + SARADC_CHANNEL(2, "adc2"), > }; > > static const struct rockchip_saradc_data saradc_data = { > @@ -141,8 +141,8 @@ static const struct rockchip_saradc_data saradc_data = { > }; > > static const struct iio_chan_spec rockchip_rk3066_tsadc_iio_channels[] = { > - ADC_CHANNEL(0, "adc0"), > - ADC_CHANNEL(1, "adc1"), > + SARADC_CHANNEL(0, "adc0"), > + SARADC_CHANNEL(1, "adc1"), > }; > > static const struct rockchip_saradc_data rk3066_tsadc_data = { > @@ -153,12 +153,12 @@ static const struct rockchip_saradc_data rk3066_tsadc_data = { > }; > > static const struct iio_chan_spec rockchip_rk3399_saradc_iio_channels[] = { > - ADC_CHANNEL(0, "adc0"), > - ADC_CHANNEL(1, "adc1"), > - ADC_CHANNEL(2, "adc2"), > - ADC_CHANNEL(3, "adc3"), > - ADC_CHANNEL(4, "adc4"), > - ADC_CHANNEL(5, "adc5"), > + SARADC_CHANNEL(0, "adc0"), > + SARADC_CHANNEL(1, "adc1"), > + SARADC_CHANNEL(2, "adc2"), > + SARADC_CHANNEL(3, "adc3"), > + SARADC_CHANNEL(4, "adc4"), > + SARADC_CHANNEL(5, "adc5"), > }; > > static const struct rockchip_saradc_data rk3399_saradc_data = {