From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55EDAC5519A for ; Sun, 26 Apr 2020 08:58:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2963920663 for ; Sun, 26 Apr 2020 08:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587891517; bh=n03uHDRrKMIWpH7lNl9PB7N8W2kFYUcb/NUNoedGpjg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=a6FZkduG+6T6UjmT9/tBVknB+cMQRRo1KK167ozPSREv503d6U8AD/H2c1G8qtgnx Czl1gmbq+hKIwfmc1RMvnWkcLclMq7d+Os1bvCFh4UxN2OSfSA4HXdB4okKHI3Tn1j B6tnynJJvGYfsjce5Eg1eyXXFznUNkbPdP4XIcwQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726165AbgDZI6g (ORCPT ); Sun, 26 Apr 2020 04:58:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:38954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbgDZI6g (ORCPT ); Sun, 26 Apr 2020 04:58:36 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 875C220661; Sun, 26 Apr 2020 08:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587891515; bh=n03uHDRrKMIWpH7lNl9PB7N8W2kFYUcb/NUNoedGpjg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zTx30wGGQzjRpKe/fS2lGLAFIClU5VocViAEZREwHQqLVw8PYm6srEGL+8X36uYd1 FmjkVOp3i9HamTBp8OuFWaTmQYoDt7f80ouDaC82vkXFV4X1dYamMPvkIIgsemMQTB IU+ONCMuV78to7xgMW7VPqzdbttUpY1gl2+oPHQk= Date: Sun, 26 Apr 2020 09:58:31 +0100 From: Jonathan Cameron To: Mathieu Othacehe Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/4] iio: vcnl4000: Factorize data reading and writing. Message-ID: <20200426095831.1472fbc9@archlinux> In-Reply-To: <20200422130856.1722-2-m.othacehe@gmail.com> References: <20200422130856.1722-1-m.othacehe@gmail.com> <20200422130856.1722-2-m.othacehe@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Apr 2020 15:08:53 +0200 Mathieu Othacehe wrote: > Factorize data reading in vcnl4000_measure into a vcnl4000_read_data > function. Also add a vcnl4000_write_data function. > > Signed-off-by: Mathieu Othacehe > --- > drivers/iio/light/vcnl4000.c | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c > index 58e97462e803..695a81e95d8d 100644 > --- a/drivers/iio/light/vcnl4000.c > +++ b/drivers/iio/light/vcnl4000.c > @@ -215,11 +215,34 @@ static int vcnl4200_init(struct vcnl4000_data *data) > return 0; > }; > > +static int vcnl4000_read_data(struct vcnl4000_data *data, u8 data_reg, int *val) > +{ > + s32 ret; > + > + ret = i2c_smbus_read_word_data(data->client, data_reg); > + if (ret < 0) > + return ret; > + > + *val = be16_to_cpu(ret); > + return 0; > +} > + > +static int vcnl4000_write_data(struct vcnl4000_data *data, u8 data_reg, int val) > +{ > + __be16 be_val; > + > + if (val > U16_MAX) > + return -ERANGE; > + > + be_val = cpu_to_be16(val); > + return i2c_smbus_write_word_data(data->client, data_reg, be_val); > +} > + > + Nitpick: One line is plenty. I can tidy this up whilst applying if we don't go to v6 for other reasons. Otherwise this looks fine. Jonathan > static int vcnl4000_measure(struct vcnl4000_data *data, u8 req_mask, > u8 rdy_mask, u8 data_reg, int *val) > { > int tries = 20; > - __be16 buf; > int ret; > > mutex_lock(&data->vcnl4000_lock); > @@ -246,13 +269,11 @@ static int vcnl4000_measure(struct vcnl4000_data *data, u8 req_mask, > goto fail; > } > > - ret = i2c_smbus_read_i2c_block_data(data->client, > - data_reg, sizeof(buf), (u8 *) &buf); > + ret = vcnl4000_read_data(data, data_reg, val); > if (ret < 0) > goto fail; > > mutex_unlock(&data->vcnl4000_lock); > - *val = be16_to_cpu(buf); > > return 0; >