Re: [PATCH v4] staging: wfx: cleanup long lines in data_tx.c

Suraj Upadhyay
2020-04-27T11:58:52Z

[-- Attachment #1: Type: text/plain, Size: 1844 bytes --]

On Mon, Apr 27, 2020 at 11:50:23AM +0000, Jerome Pouiller wrote:
> On Saturday 25 April 2020 13:32:34 CEST Suraj Upadhyay wrote:
> > Break lines with length over 80 characters to
> > conform to the linux coding style and refactor
> > wherever necessary.
> >
> > Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
> > ---
> >
> > Changes in v4:
> > - Added a space after declaration in wfx_get_hw_rate().
> > - A checkpatch warning for this commit is retained at line 75,
> > to maintain uniformity in function declarations. (Reviewer
> > jerome suggested).
> >
> > Changes in v3:
> > - Changed the temporary variable name for the memzcmp statement
> > to is_used. (as suggested).
> > - Added a temporary ieee80211_supported_band variable to address
> > the problem in wfx_get_hw_rate() more efficiently. (not
> > suggested, but still).
> >
> > Changes in v2:
> > - Introduced a temporary variable for the memzcmp statement.
> > - Addressed the checkpatch problem with wfx_get_hw_rate().
> > - Restored the function definition of wfx_tx_get_tx_parms
> > as suggested by the reviewer.
> > - Added suggested changes for req->packet_id statement.
> >
> > drivers/staging/wfx/data_tx.c | 40 +++++++++++++++++++++++------------
> > 1 file changed, 26 insertions(+), 14 deletions(-)
>
> This patch does not contain the suggestions from Dan. However, it is
> sufficient from my personal point of view.

Yes, I considered them but thought it would be bad to introduce a new
variable at every iteration of the for-loop.

> Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>

Thanks Jerome, This was my first patch to the linux kernel.

>
> --
> Jérôme Pouiller
>

Regards,

Suraj Upadhyay.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]