From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D30AAC54FCB for ; Mon, 27 Apr 2020 15:31:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B795A20656 for ; Mon, 27 Apr 2020 15:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728142AbgD0PbN (ORCPT ); Mon, 27 Apr 2020 11:31:13 -0400 Received: from sauhun.de ([88.99.104.3]:59292 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbgD0PbM (ORCPT ); Mon, 27 Apr 2020 11:31:12 -0400 Received: from localhost (p54B330D3.dip0.t-ipconnect.de [84.179.48.211]) by pokefinder.org (Postfix) with ESMTPSA id 68B992C1F66; Mon, 27 Apr 2020 17:31:09 +0200 (CEST) Date: Mon, 27 Apr 2020 17:31:07 +0200 From: Wolfram Sang To: Thierry Reding Cc: Dmitry Osipenko , Jon Hunter , Laxman Dewangan , Manikanta Maddireddy , Vidya Sagar , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time Message-ID: <20200427153106.GA8113@kunai> References: <79f6560e-dbb5-0ae1-49f8-cf1cd95396ec@nvidia.com> <20200427074837.GC3451400@ulmo> <20200427103851.GB24446@kunai> <20200427141922.GD3464906@ulmo> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: <20200427141922.GD3464906@ulmo> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Yes, that bug should be fixed anyway. But that doesn't justify breaking > suspend/resume completely, which *is* a regression. >=20 > Look, I'm not saying that we should drop this patch altogether. All I'm > saying is that we should postpone it so that we can: a) get suspend and > resume working again (and by doing so make sure no other suspend/resume > regressions silently creep in, because that always seems to happen when > you're not looking) and b) fix any preexisting issues without possibly > scrambling the result with this perhaps unrelated fix. >=20 > So, again, I think the safest road forward is to back this one out for > now, fix whatever this other bug is and once suspend/resume is working > properly again we can revisit this patch based on a known-good baseline. I am with you here. I want to add that the proper fix should be developed without thinking too much about stable in the first place. *When* we have a proper working fix, then we can think about making it "more" suitable for backporting. Yet, it may also be a result that older kernels need a different solution. Or have no solution at all, in case they can't do atomic_transfers and this is needed. D'accord? --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl6m+rYACgkQFA3kzBSg KbbGqw//cZv3rO5AhOcCCxeJFxoGIgIv9CidGK0fmKlYf0RLugGFMb0p4djzlUIG SqC/DZviHJVrmLbQgWChpBlwgIHdLoQNICqa8mNp5/dDfpsfC+ipjKG0cIiPTHhF Xih33dEwEp89eAxjb583BPUtMu6QGd8npiTyexDAiWFow0uYzms9JGZUGlAujZg0 3tbbdQAHjW7bH4XtLcVl8umKGNV5zaIrdvDQl2rFm9Q+BRj6jN/zGKefFptsJols dLo76cXnTCdaHD5NRLMJESULyDUKSCP+C12d7KZ3PBsPPnBHAecze88WkmJzLqR1 5l8GKHV9aNWJ4tmjr/B0rujvFZThpTJ8WNaxrYUqC5Lc27tiblLsJTfG04d9u6He jEXc0Osn+UQhmnoY0xBGUkXOict6u7beNE051fDqH6fvNUk1X5FZLobi9eVnsj10 B4r2Z37jvKVRqz2W1vxkAAYrHdIzX+r/rJR7jIa8MjADuFpDSEpONkG10LKF6rnG Kyq9vlETJtN7FMvJ3gfWC89N93CXHXTiuJf1k9d1C2rJxTtvXf2wmppxBTE81ZES B29+V239qytKHdZOKrVZEqCsmnml9ufrdcRSkjm+yXIst6M1zX8uchC5RaEgkDeK 40gJRr3GD/E8OWXEJ7gdWHwf63p8yWeTthkBn+2NlHVImCFkbs8= =aG5Q -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--