From: Greg KH <gregkh@linuxfoundation.org>
To: John Oldman <john.oldman@polehill.co.uk>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else-if statements
Date: Mon, 27 Apr 2020 18:04:30 +0200 [thread overview]
Message-ID: <20200427160430.GA3549342@kroah.com> (raw)
In-Reply-To: <20200427152442.26597-2-john.oldman@polehill.co.uk>
On Mon, Apr 27, 2020 at 04:24:42PM +0100, John Oldman wrote:
> Make a better job of fixing coding style issues, this time fixing
> all blocks as per Joe Perches' comment.
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
> drivers/staging/rts5208/rtsx.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index ca836ca2ee81..e16a7b9c3203 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -402,19 +402,15 @@ static int rtsx_control_thread(void *__dev)
> if (chip->srb->sc_data_direction == DMA_BIDIRECTIONAL) {
> dev_err(&dev->pci->dev, "UNKNOWN data direction\n");
> chip->srb->result = DID_ERROR << 16;
> - }
> -
> - /* reject if target != 0 or if LUN is higher than
> - * the maximum known LUN
> - */
> - else if (chip->srb->device->id) {
> + } else if (chip->srb->device->id) {
> + /* reject if target != 0 or if LUN is higher than
> + * the maximum known LUN
> + */
> dev_err(&dev->pci->dev, "Bad target number (%d:%d)\n",
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - else if (chip->srb->device->lun > chip->max_lun) {
> + } else if (chip->srb->device->lun > chip->max_lun) {
> dev_err(&dev->pci->dev, "Bad LUN (%d:%d)\n",
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> --
> 2.17.1
Why is this not just one patch?
next prev parent reply other threads:[~2020-04-27 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 15:24 [PATCH 1/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else statement issue John Oldman
2020-04-27 15:24 ` [PATCH 2/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else-if statements John Oldman
2020-04-27 16:04 ` Greg KH [this message]
2020-04-27 17:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427160430.GA3549342@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=john.oldman@polehill.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox