From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38CB8C4CECC for ; Mon, 27 Apr 2020 18:49:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2911920728 for ; Mon, 27 Apr 2020 18:49:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726650AbgD0StW (ORCPT ); Mon, 27 Apr 2020 14:49:22 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:42158 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726525AbgD0StW (ORCPT ); Mon, 27 Apr 2020 14:49:22 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 062D220026; Mon, 27 Apr 2020 20:49:15 +0200 (CEST) Date: Mon, 27 Apr 2020 20:49:09 +0200 From: Sam Ravnborg To: Xin Ji Cc: devel@driverdev.osuosl.org, Laurent Pinchart , Andrzej Hajda , Nicolas Boichat , Jernej Skrabec , Nicolas Boichat , Pi-Hsun Shih , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sheng Pan , Dan Carpenter Subject: Re: [PATCH v8 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding Message-ID: <20200427184909.GA15880@ravnborg.org> References: <67ccead807b7d0a50df479cab2c9d325041224bc.1587880280.git.xji@analogixsemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67ccead807b7d0a50df479cab2c9d325041224bc.1587880280.git.xji@analogixsemi.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=ULXz4hXy c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=VwQbUJbxAAAA:8 a=bbNUuHX0AAAA:8 a=gEfo2CItAAAA:8 a=5HKp4fn5R8_46mwjT_sA:9 a=tXNADfTO3e5-O_bI:21 a=RL_1sUc0Wx0J8rAF:21 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=3b-t3vAtY4IUXy2q2Ylb:22 a=sptkURWiP4Gy88Gu7hUp:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xin Ji On Mon, Apr 27, 2020 at 02:17:46PM +0800, Xin Ji wrote: > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI to DisplayPort 1.3 4K. Thanks for providing this binding. When you re-submit please also send to devicetree@vger.kernel.org. Running the binding through dt_binding_check gives me: /home/sam/drm/linux.git/Documentation/devicetree/bindings/display/bridge/anx7625.yaml: ignoring, error in schema: warning: no schema found in file: /home/sam/drm/linux.git/Documentation/devicetree/bindings/display/bridge/anx7625.yaml make[2]: *** [/home/sam/drm/linux.git/Documentation/devicetree/bindings/Makefile:42: Documentation/devicetree/bindings/processed-schema.yaml] Error 255 make[2]: *** Waiting for unfinished jobs.... /home/sam/drm/linux.git/Documentation/devicetree/bindings/display/bridge/anx7625.yaml: Additional properties are not allowed ('example' was unexpected) /home/sam/drm/linux.git/Documentation/devicetree/bindings/display/bridge/anx7625.yaml: Additional properties are not allowed ('example' was unexpected) See writing-schemas.rst for instruction installing tools etc. > > You can add support to your board with binding. > > Example: > anx7625_bridge: encoder@58 { > compatible = "analogix,anx7625"; > reg = <0x58>; > status = "okay"; > panel-flags = <1>; > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; > #address-cells = <1>; > #size-cells = <0>; > > port@0 { > reg = <0>; > anx_1_in: endpoint { > remote-endpoint = <&mipi_dsi>; > }; > }; > > port@2 { > reg = <2>; > anx_1_out: endpoint { > remote-endpoint = <&panel_in>; > }; > }; > }; > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/anx7625.yaml | 91 ++++++++++++++++++++++ > 1 file changed, 91 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml > new file mode 100644 > index 0000000..1149ebb > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml Name the file "analogix,anx7625.yaml". (We should rename anx6345.yaml, so others do not omit the company name) > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 Analogix Semiconductor, Inc. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) > + > +maintainers: > + - Xin Ji > + > +description: | > + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter > + designed for portable devices. > + > +properties: > + "#address-cells": true > + "#size-cells": true > + > + compatible: > + items: > + - const: analogix,anx7625 > + > + reg: > + maxItems: 1 > + > + panel-flags: > + description: indicate the panel is internal or external. > + maxItems: 1 This property hint at something needs to be modelled in a different way. I do not recall other bindings need similar info. > + > + interrupts: > + maxItems: 1 A description would be nice. > + > + enable-gpios: > + description: used for power on chip control, POWER_EN pin D2. > + maxItems: 1 > + > + reset-gpios: > + description: used for reset chip control, RESET_N pin B7. > + maxItems: 1 > + > + port@0: > + type: object > + description: > + A port node pointing to MIPI DSI host port node. > + > + port@1: > + type: object > + description: > + A port node pointing to MIPI DPI host port node. Maybe explain how it differs from port@0 and why it is optional. > + > + port@2: > + type: object > + description: > + A port node pointing to panel port node. Unless there is a good reason not to then please use a ports node, like you see in almost (all?) other bridge bindings. > + > +required: > + - "#address-cells" > + - "#size-cells" > + - compatible > + - reg > + - port@0 > + - port@2 additionalProperties: false?? > + > +example: It must be named "examples:" - this is what dt_binding_check complains about. > + - | > + anx7625_bridge: encoder@58 { > + compatible = "analogix,anx7625"; > + reg = <0x58>; > + status = "okay"; No status in examples. > + panel-flags = <1>; > + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; You need to include a header file to pull in GPIO_ACTIVE_HIGH - see what other bindings do. > + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; Be consistent with indent. My personal preference is 4 spaces. > + anx_1_in: endpoint { > + remote-endpoint = <&mipi_dsi>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + anx_1_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; Lot's of small comments. But if this is your first binding then this is expected. Looks forward for v2. Sam