Re: [PATCH v2 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c

Miquel Raynal
2020-04-27T20:09:47Z

Hi Gustavo,

"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote on Mon, 27 Apr
2020 14:56:08 -0500:

> Function print_drs_error is only used in drivers/mtd/lpddr/lpddr_cmds.c
> so, better to move it there.
>
> Also, notice that there's no need for inline as the function is used
> once. Lastly, fix the following checkpatch warning:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +static void print_drs_error(unsigned dsr)
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
> - Remove inline from print_drs_error and update changelog text,
> accordingly.
>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl