Re: [PATCH v2 1/3] mtd: lpddr: Fix bad logic in print_drs_error

Gustavo A. R. Silva
2020-05-19T16:17:40Z

Hi all,

Friendly ping: who can take this?

Thanks
--
Gustavo

On 4/27/20 15:08, Miquel Raynal wrote:
> Hi Gustavo,
>
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote on Mon, 27 Apr
> 2020 14:50:37 -0500:
>
>> Update logic for broken test. Use a more common logging style.
>>
>> It appears the logic in this function is broken for the
>> consecutive tests of
>>
>> if (prog_status & 0x3)
>> ...
>> else if (prog_status & 0x2)
>> ...
>> else (prog_status & 0x1)
>> ...
>>
>> Likely the first test should be
>>
>> if ((prog_status & 0x3) == 0x3)
>>
>> Found by inspection of include files using printk.
>>
>> Fixes: eb3db27507f7 ("[MTD] LPDDR PFOW definition")
>> Cc: stable@vger.kernel.org
>> Reported-by: Joe Perches <joe@perches.com>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> Changes in v2:
>> - None.
>>
>> include/linux/mtd/pfow.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/mtd/pfow.h b/include/linux/mtd/pfow.h
>> index 122f3439e1af..c65d7a3be3c6 100644
>> --- a/include/linux/mtd/pfow.h
>> +++ b/include/linux/mtd/pfow.h
>> @@ -128,7 +128,7 @@ static inline void print_drs_error(unsigned dsr)
>>
>> if (!(dsr & DSR_AVAILABLE))
>> printk(KERN_NOTICE"DSR.15: (0) Device not Available\n");
>> - if (prog_status & 0x03)
>> + if ((prog_status & 0x03) == 0x03)
>> printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid "
>> "half with 41h command\n");
>> else if (prog_status & 0x02)
>
>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
>
> Thanks,
> Miquèl
>