Re: [PATCH v3] perf inject --jit: Remove //anon mmap events

Re: [PATCH v3] perf inject --jit: Remove //anon mmap events

[Francois Saint-Jacques]

I'd just like to weight in that this patch fixes the issue Steve
mentioned. I have a local experiment using LLVM's ORC jit with jitdump
support and couldn't get any symbols recognized by perf until applying
this patch.

Thank you,
François

Re: [PATCH v3] perf inject --jit: Remove //anon mmap events

[Jiri Olsa]

On Sat, Dec 28, 2019 at 01:02:13PM -0500, Francois Saint-Jacques wrote:
> I'd just like to weight in that this patch fixes the issue Steve
> mentioned. I have a local experiment using LLVM's ORC jit with jitdump
> support and couldn't get any symbols recognized by perf until applying
> this patch.

great, please reply to the orginal patch post with tested-by

Arnaldo, could you please check on this one?

there was some discussion about used clockid, but Stephane or
any other jit guys did not raise any particular concern AFAICS,
also it's simple enough to revert in case there's any issue

thanks,
jirka

> 
> Thank you,
> François
> 

RE: [EXTERNAL] Re: [PATCH v3] perf inject --jit: Remove //anon mmap events

[Steve MacLean]

> it's simple enough to revert in case there's any issue
>
> thanks,
> jirka

Can we go ahead and merge this?

Re: [EXTERNAL] Re: [PATCH v3] perf inject --jit: Remove //anon mmap events

[Jiri Olsa]

On Mon, Apr 27, 2020 at 10:03:58PM +0000, Steve MacLean wrote:
> > it's simple enough to revert in case there's any issue
> >
> > thanks,
> > jirka
> 
> Can we go ahead and merge this?
> 

I saw the explanation you posted:
  https://lore.kernel.org/lkml/CY4PR21MB0632B5EE447DA9B931CB114DF7740@CY4PR21MB0632.namprd21.prod.outlook.com/

could you please add it to the patch changelog and repost?

as I said I'm ok with the patch, Stephane?

jirka