From: Lee Jones <lee.jones@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/4] mfd: wm8994: Fix driver operation if loaded as modules
Date: Tue, 28 Apr 2020 11:37:02 +0100 [thread overview]
Message-ID: <20200428103702.GQ3559@dell> (raw)
In-Reply-To: <20200427074832.22134-2-m.szyprowski@samsung.com>
On Mon, 27 Apr 2020, Marek Szyprowski wrote:
> WM8994 chip has built-in regulators, which might be used for chip
> operation. They are controlled by a separate wm8994-regulator driver,
> which should be loaded before this driver calls regulator_get(), because
> that driver also provides consumer-supply mapping for the them. If that
> driver is not yet loaded, regulator core substitute them with dummy
> regulator, what breaks chip operation, because the built-in regulators are
> never enabled. Fix this by annotating this driver with MODULE_SOFTDEP()
> "pre" dependency to "wm8994_regulator" module.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> drivers/mfd/wm8994-core.c | 1 +
> 1 file changed, 1 insertion(+)
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-04-28 10:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200427074841eucas1p10523e8e342a8fa2d7cdfb2bc4e25d485@eucas1p1.samsung.com>
2020-04-27 7:48 ` [PATCH RESEND 0/4] Minor WM8994 MFD/codec fixes Marek Szyprowski
2020-04-27 7:48 ` [PATCH 1/4] mfd: wm8994: Fix driver operation if loaded as modules Marek Szyprowski
2020-04-28 10:37 ` Lee Jones [this message]
2020-05-22 8:06 ` Lee Jones
2020-04-27 7:48 ` [PATCH 2/4] mfd: wm8994: Fix unbalanced calls to regulator_bulk_disable() Marek Szyprowski
2020-04-28 10:37 ` Lee Jones
2020-05-22 8:07 ` Lee Jones
2020-04-27 7:48 ` [PATCH 3/4] mfd: wm8994: Silence warning about supplies during deferred probe Marek Szyprowski
2020-04-27 10:31 ` Charles Keepax
2020-05-22 8:07 ` Lee Jones
2020-04-27 7:48 ` [PATCH 4/4] ASoC: wm8994: Silence warnings " Marek Szyprowski
2020-04-27 10:32 ` Charles Keepax
2020-04-27 11:22 ` Mark Brown
2020-04-28 10:36 ` Lee Jones
2020-04-28 11:14 ` Mark Brown
2020-04-29 7:15 ` Lee Jones
2020-04-29 9:56 ` Mark Brown
2020-05-22 7:57 ` [PATCH RESEND 0/4] Minor WM8994 MFD/codec fixes Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428103702.GQ3559@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=patches@opensource.cirrus.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox