From: Mark Brown <broonie@kernel.org>
To: "Leslie Hsia(夏邦進_Pegatron)" <Leslie_Hsia@pegatroncorp.com>
Cc: "knaack.h@gmx.de" <knaack.h@gmx.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Hermes Hsieh(謝旻劭_Pegatron)" <Hermes_Hsieh@pegatroncorp.com>,
"jesse.sung@canonical.com" <jesse.sung@canonical.com>,
"jic23@kernel.org" <jic23@kernel.org>
Subject: Re: [PATCH] subsystem: Amplifier driver for TAS5805M,Texas instruments
Date: Tue, 28 Apr 2020 12:30:33 +0100 [thread overview]
Message-ID: <20200428113033.GE5677@sirena.org.uk> (raw)
In-Reply-To: <754706C925201D4896E92CCAD6B38E4401F0F733E3@PTW-EX-37.PEGA.CORP.PEGATRON>
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
On Tue, Apr 28, 2020 at 10:43:18AM +0000, Leslie Hsia(夏邦進_Pegatron) wrote:
> * Author: Leslie Hsia
> * Amplifier driver for TAS5805M, initial the amplifier and set the sound parameter.
> * Signed-off-by: Leslie Hsia <Leslie_Hsia@pegatroncorp.com<mailto:Leslie_Hsia@pegatroncorp.com>>
Please follow the patch submission process that is described in
Documentation/process/submitting-patches.rst in the kernel source. Take
a look at other submissions on the list and follow a similar process.
There also appear to be both IIO and ASoC drivers in there which is at
best a bit weird.
Having done a quick scan through your code it doesn't actually seem to
integrate with the subsystem at all (there's no
snd_soc_register_codec())
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next parent reply other threads:[~2020-04-28 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <754706C925201D4896E92CCAD6B38E4401F0F733E3@PTW-EX-37.PEGA.CORP.PEGATRON>
2020-04-28 11:30 ` Mark Brown [this message]
2020-04-28 18:27 ` [PATCH] subsystem: Amplifier driver for TAS5805M,Texas instruments Leslie Hsia(夏邦進_Pegatron)
2020-04-29 12:49 ` Mark Brown
[not found] <754706C925201D4896E92CCAD6B38E4401F0F6B825@PTW-EX-38.PEGA.CORP.PEGATRON>
2020-04-26 8:55 ` Jonathan Cameron
[not found] <754706C925201D4896E92CCAD6B38E4401F0F61013@PTW-EX-37.PEGA.CORP.PEGATRON>
2020-04-05 11:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428113033.GE5677@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Hermes_Hsieh@pegatroncorp.com \
--cc=Leslie_Hsia@pegatroncorp.com \
--cc=jesse.sung@canonical.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox