From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Cosmin-Gabriel Samoila <cosmin.samoila@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_easrc: mark PM functions __maybe_unused
Date: Tue, 28 Apr 2020 18:56:34 -0700 [thread overview]
Message-ID: <20200429015632.GA15142@Asurada-Nvidia> (raw)
In-Reply-To: <20200428212847.2926376-1-arnd@arndb.de>
On Tue, Apr 28, 2020 at 11:28:08PM +0200, Arnd Bergmann wrote:
> ifdefs are hard, and in this driver the suspend/resume functions are
> the only callers of some other helpers that trigger a harmless warning
> when CONFIG_PM is disabled:
>
> sound/soc/fsl/fsl_easrc.c:1807:12: warning: 'fsl_easrc_get_firmware' defined but not used [-Wunused-function]
> 1807 | static int fsl_easrc_get_firmware(struct fsl_asrc *easrc)
> | ^~~~~~~~~~~~~~~~~~~~~~
> sound/soc/fsl/fsl_easrc.c:303:12: warning: 'fsl_easrc_resampler_config' defined but not used [-Wunused-function]
> 303 | static int fsl_easrc_resampler_config(struct fsl_asrc *easrc)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Remove the #ifdef and just mark the callers as __maybe_unused to
> suppress the warnings altogether.
>
> Fixes: 955ac624058f ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
next prev parent reply other threads:[~2020-04-29 1:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 21:28 [PATCH] ASoC: fsl_easrc: mark PM functions __maybe_unused Arnd Bergmann
2020-04-29 1:56 ` Nicolin Chen [this message]
2020-04-29 16:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429015632.GA15142@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cosmin.samoila@nxp.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox