* Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint
@ 2020-04-27 10:38 Markus Elfring
2020-04-29 4:58 ` Sayali Lokhande
0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2020-04-27 10:38 UTC (permalink / raw)
To: Sayali Lokhande, linux-f2fs-devel, Jaegeuk Kim, Chao Yu
Cc: linux-kernel, kernel-janitors
> … This results in deadlock as
> iput() tries to hold cp_rwsem, which is already held at the
> beginning by checkpoint->block_operations().
Will another imperative wording become helpful besides the provided information
for this change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
Would you like to add the tag “Fixes” because of adjustments
for the data synchronisation?
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint
2020-04-27 10:38 [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint Markus Elfring
@ 2020-04-29 4:58 ` Sayali Lokhande
2020-04-29 12:44 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Sayali Lokhande @ 2020-04-29 4:58 UTC (permalink / raw)
To: Markus Elfring, linux-f2fs-devel, Jaegeuk Kim, Chao Yu
Cc: linux-kernel, kernel-janitors
Hi Markus
On 4/27/2020 4:08 PM, Markus Elfring wrote:
>> … This results in deadlock as
>> iput() tries to hold cp_rwsem, which is already held at the
>> beginning by checkpoint->block_operations().
> Will another imperative wording become helpful besides the provided information
> for this change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
>
> Would you like to add the tag “Fixes” because of adjustments
> for the data synchronisation?
I couldn't find any past commit which suits to be added under "Fixes"
here. Let me know if you have any other comment.
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint
2020-04-29 4:58 ` Sayali Lokhande
@ 2020-04-29 12:44 ` Dan Carpenter
2020-04-29 16:52 ` Sayali Lokhande
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2020-04-29 12:44 UTC (permalink / raw)
To: Sayali Lokhande
Cc: Markus Elfring, linux-f2fs-devel, Jaegeuk Kim, Chao Yu,
linux-kernel, kernel-janitors
On Wed, Apr 29, 2020 at 10:28:36AM +0530, Sayali Lokhande wrote:
> Hi Markus
>
> On 4/27/2020 4:08 PM, Markus Elfring wrote:
> > > … This results in deadlock as
> > > iput() tries to hold cp_rwsem, which is already held at the
> > > beginning by checkpoint->block_operations().
> > Will another imperative wording become helpful besides the provided information
> > for this change description?
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
> >
> > Would you like to add the tag “Fixes” because of adjustments
> > for the data synchronisation?
>
> I couldn't find any past commit which suits to be added under "Fixes" here.
> Let me know if you have any other comment.
This looks really old. Maybe commit 399368372ed9 ("f2fs: introduce a
new global lock scheme")?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint
2020-04-29 12:44 ` Dan Carpenter
@ 2020-04-29 16:52 ` Sayali Lokhande
0 siblings, 0 replies; 4+ messages in thread
From: Sayali Lokhande @ 2020-04-29 16:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: Markus Elfring, linux-f2fs-devel, Jaegeuk Kim, Chao Yu,
linux-kernel, kernel-janitors
On 4/29/2020 6:14 PM, Dan Carpenter wrote:
> On Wed, Apr 29, 2020 at 10:28:36AM +0530, Sayali Lokhande wrote:
>> Hi Markus
>>
>> On 4/27/2020 4:08 PM, Markus Elfring wrote:
>>>> … This results in deadlock as
>>>> iput() tries to hold cp_rwsem, which is already held at the
>>>> beginning by checkpoint->block_operations().
>>> Will another imperative wording become helpful besides the provided information
>>> for this change description?
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
>>>
>>> Would you like to add the tag “Fixes” because of adjustments
>>> for the data synchronisation?
>> I couldn't find any past commit which suits to be added under "Fixes" here.
>> Let me know if you have any other comment.
> This looks really old. Maybe commit 399368372ed9 ("f2fs: introduce a
> new global lock scheme")?
Yes. Let me update it in Fixes tag in V3 and post it. Thanks for
pointing it.
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-29 16:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-27 10:38 [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint Markus Elfring
2020-04-29 4:58 ` Sayali Lokhande
2020-04-29 12:44 ` Dan Carpenter
2020-04-29 16:52 ` Sayali Lokhande
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox