From: Greg KH <greg@kroah.com>
To: Akira Shimahara <akira215corp@gmail.com>
Cc: zbr@ioremap.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] w1_therm: fix reset_select_slave. Creating w1_therm.h
Date: Wed, 29 Apr 2020 15:43:57 +0200 [thread overview]
Message-ID: <20200429134357.GA2132814@kroah.com> (raw)
In-Reply-To: <20200429133048.139402-1-akira215corp@gmail.com>
On Wed, Apr 29, 2020 at 03:30:48PM +0200, Akira Shimahara wrote:
> Patch for enhancement of w1_therm module.
> - Creating a w1_therm.h file to clean up the code and documenting it.
> - fix reset_select_slave function: w1_reset_select_slave() from w1_io.c
> could not be used here because a SKIP ROM command is sent if only
> one device is on the line. At the beginning of the search process,
> sl->master->slave_count is 1 even if more devices are on the line,
> causing data collision in the bus.
This should be three different patches, one to create the file by moving
the code, one to document it, and the last to do the fix.
thanks,
greg k-h
next prev parent reply other threads:[~2020-04-29 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 13:30 [PATCH v3 1/5] w1_therm: fix reset_select_slave. Creating w1_therm.h Akira Shimahara
2020-04-29 13:43 ` Greg KH [this message]
2020-04-29 13:48 ` Akira shimahara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429134357.GA2132814@kroah.com \
--to=greg@kroah.com \
--cc=akira215corp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox