From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3017C83004 for ; Wed, 29 Apr 2020 19:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A11D7205C9 for ; Wed, 29 Apr 2020 19:19:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kAW87UsW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727042AbgD2TTx (ORCPT ); Wed, 29 Apr 2020 15:19:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726929AbgD2TTw (ORCPT ); Wed, 29 Apr 2020 15:19:52 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EE28C035494 for ; Wed, 29 Apr 2020 12:19:52 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id x77so1557453pfc.0 for ; Wed, 29 Apr 2020 12:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3yS3SDIAxgoI+OCUuH6+Xx3tuGso0aTCeG8T3YqniwU=; b=kAW87UsWv8BfldJU8firQKssmmNKdHSJ/uH0CxVGXED+CIBf7O7HPb682q9RG2cheP CqUALbpH8DNabf8/TtXUlH4a6QD4JuzFqdwO98QklnOZrLH3SkRkeapQ3l8zxB91lW+c jUxygCHAQLmS7p2c6aUXvTLH2ix1MjrA8Ej/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3yS3SDIAxgoI+OCUuH6+Xx3tuGso0aTCeG8T3YqniwU=; b=p9C5xKszEzwCDGVOFXUlaSGq2Y+jM0KFFXKYIxytlbxBdyGCba5e9xLx4ximJlpXHy 9HgOn6nWwqsNgtxspcWID+3b9Va/hnb8uKtoDMoO+3AyJ6SQFjhiX113+S+VTeWpEVhI iTGppR9ICr7kLLkhFiuaUO7ZPctI/xi0/J9bZaFXFf1kJoIXGLXf5lAOknBdpkF30Om9 WkXHquItbS4jFzqXPbJuJGpX2/IR3THuz5LARRx4y1hXgE2Abrr69uwBLBxq0BEpWEDj VlVf8dPo41MQzzM6csbh849WNMi0+vcYJ+Hadm77VLi/HP1Zdopn57PDfosfUyB50BIH UGvw== X-Gm-Message-State: AGi0PuZkyKxa3HyYObGhiCM8cLosDzFu2mABBQjtgyU+enMkATyG43pa /4M8rrFY2exzfo4AO/gQkNQCXA== X-Google-Smtp-Source: APiQypL1Gf97EDr2VlhCZCv3oqFpzbGvV9eP/VHq+9IO0hxAjTqes6LlM/GSXv+aDrJ1AbJJqROWZw== X-Received: by 2002:a63:495b:: with SMTP id y27mr3550206pgk.218.1588187991710; Wed, 29 Apr 2020 12:19:51 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id d12sm1731525pfq.36.2020.04.29.12.19.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 12:19:50 -0700 (PDT) Date: Wed, 29 Apr 2020 12:19:49 -0700 From: Matthias Kaehlcke To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , Doug Anderson , Kishon Vijay Abraham I , Mark Rutland , Rob Herring , Sandeep Maheswaram , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Manu Gautam , Tanmay Shah , robdclark@gmail.com, abhinavk@codeaurora.org, nganji@codeaurora.org, jsanka@codeaurora.org, aravindh@codeaurora.org, hoegsberg@google.com, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v5 1/3] dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml Message-ID: <20200429191949.GV4525@google.com> References: <1585809534-11244-1-git-send-email-sanm@codeaurora.org> <1585809534-11244-2-git-send-email-sanm@codeaurora.org> <158689927748.105027.5367465616284167712@swboyd.mtv.corp.google.com> <20200423171436.GJ199755@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200423171436.GJ199755@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sandeep, On Thu, Apr 23, 2020 at 10:14:36AM -0700, Matthias Kaehlcke wrote: > Hi Sandeep, > > On Tue, Apr 14, 2020 at 02:21:17PM -0700, Stephen Boyd wrote: > > Quoting Sandeep Maheswaram (2020-04-01 23:38:52) > > > Convert QMP PHY bindings to DT schema format using json-schema. > > > > > > Signed-off-by: Sandeep Maheswaram > > > --- > > > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 332 +++++++++++++++++++++ > > > .../devicetree/bindings/phy/qcom-qmp-phy.txt | 242 --------------- > > > 2 files changed, 332 insertions(+), 242 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > > delete mode 100644 Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > > > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > > new file mode 100644 > > > index 0000000..18a8985 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > > @@ -0,0 +1,332 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > + > > > +%YAML 1.2 > > > +--- > > > +$id: "http://devicetree.org/schemas/phy/qcom,qmp-phy.yaml#" > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > > + > > > +title: Qualcomm QMP PHY controller > > > + > > > +maintainers: > > > + - Manu Gautam > > > + > > > +description: > > > + QMP phy controller supports physical layer functionality for a number of > > > + controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - qcom,ipq8074-qmp-pcie-phy > > > + - qcom,msm8996-qmp-pcie-phy > > > + - qcom,msm8996-qmp-ufs-phy > > > + - qcom,msm8996-qmp-usb3-phy > > > + - qcom,msm8998-qmp-pcie-phy > > > + - qcom,msm8998-qmp-ufs-phy > > > + - qcom,msm8998-qmp-usb3-phy > > > + - qcom,sdm845-qhp-pcie-phy > > > + - qcom,sdm845-qmp-pcie-phy > > > + - qcom,sdm845-qmp-ufs-phy > > > + - qcom,sdm845-qmp-usb3-phy > > > + - qcom,sdm845-qmp-usb3-uni-phy > > > + - qcom,sm8150-qmp-ufs-phy > > > + > > > + reg: > > > + minItems: 1 > > > + items: > > > + - description: Address and length of PHY's common serdes block. > > > + - description: Address and length of the DP_COM control block. > > > > This DP_COM block is only for one compatible. Is it possible to split > > that compatible out of this binding so we can enforce the reg property > > being either one or two items? > > > > In addition, I don't quite understand how this binding is supposed to > > work with the DP phy that sits inside qcom,sdm845-qmp-usb3-phy and then > > gets muxed out on the USB pins on sdm845 and sc7180 SoCs. Can you fill > > me in on how we plan to share the pins between the two phys so that all > > the combinations of DP and USB over the type-c pins will work here? My > > understanding is that the pins that are controlled by this hardware > > block are basically a full USB type-c connector pinout[1] (except that > > D+/D- isn't there and the VBUS and CC lines go to the PMIC). Either way, > > we get the TX1/2 and RX1/2 pins to use, so we can do 4x lanes of DP or > > 2x lanes DP and 2x lanes of USB. There's also a type-c orientation > > flipper bit that can flip the DP and USB phy lanes to the correct TX/RX > > pins on the SoC. And then the DP phy has a lane remapper to change the > > logical DP lane to the physical DP lane. It's a complex piece of > > hardware that isn't fully represented by this binding. > > > > [1] https://en.wikipedia.org/wiki/USB-C#/media/File:USB_Type-C_Receptacle_Pinout.svg > > Could you please answer Stephen's questions? It would be great to move > forward and get support for SC7180 landed. You posted v6, which does the split Stephen asked for, but you didn't answer his question about the pin sharing. Since this is an existing binding there is probably no reason to block it from landing, but it would still be good to clarify this. Thanks Matthias